Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: depend on python2 specifically #11397

Closed
wants to merge 1 commit into from

Conversation

rpodgorny
Copy link

@rpodgorny rpodgorny commented Feb 15, 2017

This solves the problem of not being able to build node on system
where both python2 and python3 is installed and python3 is the
default.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build system

...i will send patches for "dep" and "tools" to their respective upstream but this solves the problem for the node part.

This solves the problem of not being able to build node on system
where both python2 and python3 is installed and python3 is the
default.
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Feb 15, 2017
@mscdex
Copy link
Contributor

mscdex commented Feb 15, 2017

Hrmm... I'm curious if there are any modern platforms/distributions that only provide python and not python2 (e.g. perhaps python for 2.x and python3 for 3.x). Windows is probably one of the more obvious potential platforms that could be included in that list.

@rpodgorny
Copy link
Author

none that i'm aware of (but i'm no expert)... but, imho, at least on linux, the good practice is to have python2 and/or python3 and python being just symlink to one of those...

@jbergstroem
Copy link
Member

I think this have been brought up previously. There are too many ways python(2) is installed; I think we shouldn't rock the boat on this one. @bnoordhuis thoughts?

@Fishrock123
Copy link
Contributor

I do not have python2. OS X 10.10.5.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Feb 15, 2017

FWIW:

c:\>python2
'python2' is not recognized as an internal or external command, operable program or batch file.

I have only Python 2.7.13 on Windows 7 x64. Would python2 appear if I install Python 3x?

@bnoordhuis
Copy link
Member

I do not have python2. OS X 10.10.5.

Yes, this is the clincher. OS X systems don't have a python2 binary.

@gibfahn
Copy link
Member

gibfahn commented Feb 16, 2017

Yes, this is the clincher. OS X systems don't have a python2 binary.

Given the above, I think that #11375 is a better solution to this problem.

@rpodgorny
Copy link
Author

hmm, just found this. ...adding for reference: #9512
i'm afraid this will only keep coming as more and more systems default to python3.

@BridgeAR
Copy link
Member

As #11375 has landed and this is not going to fully work I am going to close this. If you feel that it should be reopened, please do so.

@BridgeAR BridgeAR closed this Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants