Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor common.expectsError() #11381

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 14, 2017

  • Report values in assertions.
  • Strict equality match if message is a string.
  • instanceof/typeof instead of deprecated util.isRegExp()
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test errors

* Report values in assertions.
* Strict equality match if message is a string.
* instanceof/typeof instead of deprecated util.isRegExp()
@Trott Trott added errors Issues and PRs related to JavaScript errors originated in Node.js core. test Issues and PRs related to the tests. labels Feb 14, 2017
@Trott Trott requested a review from jasnell February 14, 2017 18:50
@jasnell
Copy link
Member

jasnell commented Feb 16, 2017

@Trott
Copy link
Member Author

Trott commented Feb 17, 2017

Trott added a commit to Trott/io.js that referenced this pull request Feb 18, 2017
* Report values in assertions.
* Strict equality match if message is a string.
* instanceof/typeof instead of deprecated util.isRegExp()

PR-URL: nodejs#11381
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Feb 18, 2017

Landed in 749fac0

@Trott Trott closed this Feb 18, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 25, 2017
* Report values in assertions.
* Strict equality match if message is a string.
* instanceof/typeof instead of deprecated util.isRegExp()

PR-URL: nodejs#11381
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
@Trott Trott deleted the refactor-expectsError branch January 13, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
errors Issues and PRs related to JavaScript errors originated in Node.js core. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants