Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add msg validation to test-http-outgoing-proto #10943

Closed
wants to merge 1 commit into from
Closed

test: add msg validation to test-http-outgoing-proto #10943

wants to merge 1 commit into from

Conversation

hkalexling
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Jan 21, 2017
@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Jan 21, 2017
Trott
Trott approved these changes Jan 22, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@lpinca
Copy link
Member

lpinca commented Jan 23, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5996/

@lpinca
Copy link
Member

lpinca commented Jan 29, 2017

New CI: https://ci.nodejs.org/job/node-test-pull-request/6096/

@lpinca
Copy link
Member

lpinca commented Jan 29, 2017

Landed in 1155ade.

@lpinca lpinca closed this Jan 29, 2017
lpinca pushed a commit that referenced this pull request Jan 29, 2017
@hkalexling @lpinca
test: check error message in test-http-outgoing-proto
1155ade 
PR-URL: #10943
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 31, 2017
@hkalexling @evanlucas
test: check error message in test-http-outgoing-proto
e3a316f 
PR-URL: #10943
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 31, 2017
Merged
jasnell pushed a commit that referenced this pull request Mar 8, 2017
@hkalexling @jasnell
test: check error message in test-http-outgoing-proto
d7a94a9 
PR-URL: #10943
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@hkalexling @MylesBorins
test: check error message in test-http-outgoing-proto
d8eed12 
PR-URL: #10943
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hkalexling @lpinca @jasnell @Trott @cjihrig @mscdex @nodejs-github-bot