test: refactor test-cli-eval.js #10898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v7.x
test
mscdex
added
process
jasnell
approved these changes
Jan 19, 2017
| // interpreted as the escape character when put between quotes. | ||
| const filename = __filename.replace(/\\/g, '/'); | ||
|
|
||
| child.exec(nodejs + ' --eval "require(\'' + filename + '\')"', |
There was a problem hiding this comment.
Would be a bit more concise to use:
`${nodejs} --eval "require('${filename}')"`
PR-URL: nodejs#10898 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
PR-URL: #10898 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
PR-URL: nodejs#10898 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
PR-URL: nodejs#10898 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
This will need backport PRs if it should land on v6 or v4 |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 18, 2017
PR-URL: #10898 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
PR-URL: #10898 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
PR-URL: nodejs/node#10898 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common.mustCall().Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test