Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: delete duplicate test of noAssert in readUInt* #10791

Closed
wants to merge 1 commit into from
Closed

test: delete duplicate test of noAssert in readUInt* #10791

wants to merge 1 commit into from

Conversation

larissayvette
Copy link
Contributor

Checklist
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Deleted test for noAssert in buffer.readUInt*, since it is already present in test-buffer-read-noassert.js

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 13, 2017
Trott
Trott approved these changes Jan 13, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented Jan 13, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5851/

@mscdex mscdex added the buffer Issues and PRs related to the buffer subsystem. label Jan 13, 2017
jasnell pushed a commit that referenced this pull request Jan 16, 2017
@larissayvette @jasnell
test: delete duplicate test of noAssert in readUInt*
425563b 
PR-URL: #10791
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jan 16, 2017

Landed in 425563b

@jasnell jasnell closed this Jan 16, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@larissayvette @italoacasas
test: delete duplicate test of noAssert in readUInt*
ca71d42 
PR-URL: nodejs#10791
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@larissayvette @italoacasas
test: delete duplicate test of noAssert in readUInt*
05652b0 
PR-URL: nodejs#10791
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@larissayvette @italoacasas
test: delete duplicate test of noAssert in readUInt*
5909c65 
PR-URL: nodejs#10791
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@larissayvette @italoacasas
test: delete duplicate test of noAssert in readUInt*
77cbc26 
PR-URL: nodejs#10791
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
@larissayvette larissayvette deleted the delete-readint branch February 10, 2017 17:42
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@larissayvette @MylesBorins
test: delete duplicate test of noAssert in readUInt*
ac0d8f8 
PR-URL: #10791
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@larissayvette @MylesBorins
test: delete duplicate test of noAssert in readUInt*
e316faf 
PR-URL: #10791
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@larissayvette @Trott @jasnell @thefourtheye @mscdex @MylesBorins @nodejs-github-bot