Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for url module domainToAscii and domainToUnicode #10031

Closed

Conversation

DarylThayil
Copy link

Checklist
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

Tests

Description of change

Added tests for url.URL.domainToASCII and url.URL.domainToUnicode with see data that transforms one way, and checks, then transform backwards and checks for strictEqual

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added url Issues and PRs related to the legacy built-in url module. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Dec 1, 2016
@Trott
Copy link
Member

Trott commented Dec 5, 2016

/cc @jasnell

@Trott
Copy link
Member

Trott commented Dec 5, 2016

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. Just needs one small fix

['भारत.org', 'xn--h2brj9c.org']
];

domainWithASCII.forEach(pair => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wrap the pair in parens to match the common style

@DarylThayil
Copy link
Author

@jasnell updated, how to i kick off ci again ?

@jasnell
Copy link
Member

jasnell commented Dec 5, 2016

Still getting some linting issues...

$ make lint
./node tools/eslint/bin/eslint.js --cache --rulesdir=tools/eslint-rules \
	  benchmark lib test tools

/Users/james/Node/main/node/test/parallel/test-url-domain-ascii-unicode.js
  21:5  error  Expected indentation of 2 spaces but found 4  indent
  22:5  error  Expected indentation of 2 spaces but found 4  indent
  23:5  error  Expected indentation of 2 spaces but found 4  indent
  24:5  error  Expected indentation of 2 spaces but found 4  indent
  25:5  error  Expected indentation of 2 spaces but found 4  indent
  26:5  error  Expected indentation of 2 spaces but found 4  indent

✖ 6 problems (6 errors, 0 warnings)

make: *** [jslint] Error 1

@DarylThayil
Copy link
Author

okay cool, ill make sure and run lint from now on thanks, will update

@jasnell
Copy link
Member

jasnell commented Dec 6, 2016

@Trott
Copy link
Member

Trott commented Dec 6, 2016

CI is ✅

jasnell pushed a commit that referenced this pull request Dec 6, 2016
PR-URL: #10031
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Dec 6, 2016

Landed in f8e07d0. Thank you for the PR and for participating in the code-and-learn!

@jasnell jasnell closed this Dec 6, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 6, 2016
PR-URL: #10031
Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
PR-URL: nodejs#10031
Reviewed-By: James M Snell <jasnell@gmail.com>
@joyeecheung joyeecheung added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants