Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Refactors variables to ES6 compatible and newer assertions #10023

Closed
wants to merge 3 commits into from
Closed

test: Refactors variables to ES6 compatible and newer assertions #10023

wants to merge 3 commits into from

Commits on Dec 1, 2016

  1. test: refactors variable and assertions 

    - changes var to const/let
- changes assert.equal to assert.strictEqual

**Note: `process.on('exit')` wasn't able to change the handler to
`common.mustCall` because `common.mustCall` actually uses
`process.on('exit')` internally**
    @shri3k
    shri3k committed Dec 1, 2016
    Configuration menu
    Copy the full SHA
    52ad3f5 View commit details
    Browse the repository at this point in the history

  2. test: refactors variable and assertions 

    - changes var to const/let
- change assert.equal to assert.strictEqual

**Note: `process.on('exit')` wasn't able to change the handler to
`common.mustCall` because `common.mustCall` actually uses
`process.on('exit')` internally**
    @shri3k
    shri3k committed Dec 1, 2016
    Configuration menu
    Copy the full SHA
    219ca57 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2016

  1. test: refactors assertion 

    - changes `notEqual` to `notStrictEqual`
    @shri3k
    shri3k committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    f4c05a9 View commit details
    Browse the repository at this point in the history