Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONTRIBUTING.md assumes UNIX-like OS #7646

Closed
Trott opened this issue Jul 10, 2016 · 0 comments
Closed

CONTRIBUTING.md assumes UNIX-like OS #7646

Trott opened this issue Jul 10, 2016 · 0 comments
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. windows Issues and PRs related to the Windows platform.

Comments

@Trott
Copy link
Member

Trott commented Jul 10, 2016

Section 5 includes text all about make but doesn't provide the Windows alternative vcbuild commands.

Good first contribution...
@Trott Trott added doc Issues and PRs related to the documentations. windows Issues and PRs related to the Windows platform. good first issue Issues that are suitable for first-time contributors. labels Jul 10, 2016
@mscdex mscdex added the meta Issues and PRs related to the general management of the project. label Jul 10, 2016
@BethGriggs BethGriggs mentioned this issue Jul 18, 2016
Closed
2 tasks
@Fishrock123 Fishrock123 removed the good first issue Issues that are suitable for first-time contributors. label Jul 18, 2016
BethGriggs added a commit to BethGriggs/node that referenced this issue Jul 27, 2016
@BethGriggs
doc: remove platform assumption from CONTRIBUTING
3e59970 
- Specify that the ‘make test’ commands are Unix/OS X specific.
- Link to BUILDING.md for other platform commands.

Fixes: nodejs#7646
cjihrig pushed a commit that referenced this issue Aug 10, 2016
@BethGriggs @cjihrig
doc: remove platform assumption from CONTRIBUTING
14a0c31 
- Specify that the ‘make test’ commands are Unix/OS X specific.
- Link to BUILDING.md for other platform commands.

Fixes: #7646
PR-URL: #7783
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this issue Sep 9, 2016
@BethGriggs
doc: remove platform assumption from CONTRIBUTING
ba6982f 
- Specify that the ‘make test’ commands are Unix/OS X specific.
- Link to BUILDING.md for other platform commands.

Fixes: #7646
PR-URL: #7783
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this issue Sep 28, 2016
@BethGriggs
doc: remove platform assumption from CONTRIBUTING
c2dce10 
- Specify that the ‘make test’ commands are Unix/OS X specific.
- Link to BUILDING.md for other platform commands.

Fixes: #7646
PR-URL: #7783
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg pushed a commit that referenced this issue Oct 18, 2016
@BethGriggs @rvagg
doc: remove platform assumption from CONTRIBUTING
80206ff 
- Specify that the ‘make test’ commands are Unix/OS X specific.
- Link to BUILDING.md for other platform commands.

Fixes: #7646
PR-URL: #7783
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this issue Oct 26, 2016
@BethGriggs @MylesBorins
doc: remove platform assumption from CONTRIBUTING
d759d4e 
- Specify that the ‘make test’ commands are Unix/OS X specific.
- Link to BUILDING.md for other platform commands.

Fixes: #7646
PR-URL: #7783
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: remove platform assumption from CONTRIBUTING BethGriggs/node
3 participants
@mscdex @Trott @Fishrock123