Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate flaky test-inspect-async-hook-setup-at-inspect on Windows 2008r2 in CI #26798

Closed
Trott opened this issue Mar 20, 2019 · 16 comments · Fixed by #26866
Closed

investigate flaky test-inspect-async-hook-setup-at-inspect on Windows 2008r2 in CI #26798

Trott opened this issue Mar 20, 2019 · 16 comments · Fixed by #26866
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. inspector Issues and PRs related to the V8 inspector protocol windows Issues and PRs related to the Windows platform.

Comments

@Trott
Copy link
Member

Trott commented Mar 20, 2019

Getting this non-stop in win2008r2 VS 2017 in CI.

https://ci.nodejs.org/job/node-test-binary-windows/24664/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=3/console

test-rackspace-win2008r2-x64-3

21:36:40 not ok 314 parallel/test-inspect-async-hook-setup-at-inspect
21:36:40   ---
21:36:40   duration_ms: 0.516
21:36:40   severity: fail
21:36:40   exitcode: 1
21:36:40   stack: |-
21:36:40     [test] Connecting to a child Node process
21:36:40     [test] Testing /json/list
21:36:40     [err] Debugger listening on ws://127.0.0.1:52961/4afeaa3a-d321-4eaf-9ddd-2954cee7e45e
21:36:40     [err] For help, see: https://nodejs.org/en/docs/inspector
21:36:40     [err] 
21:36:40     [err] Debugger attached.
21:36:40     [err] 
21:36:40     [err] FATAL ERROR: node::inspector::Agent::ToggleAsyncHook Cannot toggle Inspector's AsyncHook, please report this.
21:36:40     [err] 
21:36:40     [err]  1: 000000013F5192FF napi_wrap+84399
21:36:40     [err] 
21:36:40     [err]  2: 000000013F4D0BD6 uv_loop_fork+44166
21:36:40     [err]  3: 000000013F4D1726 uv_loop_fork+47062
21:36:40     [err]  4: 000000013F4D1309 uv_loop_fork+46009
21:36:40     [err]  5: 000000013F4387A3 std::basic_ios<char,std::char_traits<char> >::imbue+76147
21:36:40     [err]  6: 000000013FA4EC27 v8_inspector::protocol::Debugger::API::SearchMatch::fromJSONString+242135
21:36:40     [err]  7: 000000013FA2D64C v8_inspector::protocol::Debugger::API::SearchMatch::fromJSONString+105468
21:36:40     [err]  8: 000000013FA16CFF v8_inspector::protocol::Debugger::API::SearchMatch::fromJSONString+12975
21:36:40     [err]  9: 000000013FA0FFFF v8_inspector::protocol::Runtime::API::StackTraceId::fromJSONString+33039
21:36:40     [err] 10: 000000013FA00B1D v8::internal::Factory::zero_string+23837
21:36:40     [err] 11: 000000013F805063 v8_inspector::V8InspectorSession::canDispatchMethod+675
21:36:40     [err] 12: 000000013F4393DA std::basic_ios<char,std::char_traits<char> >::imbue+79274
21:36:40     [err] 13: 000000013F4373B6 std::basic_ios<char,std::char_traits<char> >::imbue+71046
21:36:40     [err] 14: 000000013F4273CE std::basic_ios<char,std::char_traits<char> >::imbue+5534
21:36:40     [err] 15: 000000013F42642E std::basic_ios<char,std::char_traits<char> >::imbue+1534
21:36:40     [err] 16: 000000013F426F4B std::basic_ios<char,std::char_traits<char> >::imbue+4379
21:36:40     [err] 17: 000000013F427557 std::basic_ios<char,std::char_traits<char> >::imbue+5927
21:36:40     [err] 18: 000000013F8D4465 v8::internal::Isolate::InvalidatePromiseHookProtector+1029
21:36:40     [err] 19: 000000013F8B121E v8::internal::StackGuard::HandleInterrupts+398
21:36:40     [err] 20: 000000013FBA3DB5 v8::internal::OptimizingCompileDispatcher::Unblock+53381
21:36:40     [err] 21: 000000014003D34F v8::internal::interpreter::BytecodeRegisterOptimizer::RegisterTransfer+1271791
21:36:40     [err] 
21:36:40     { Error: read ECONNRESET
21:36:40         at TCP.onStreamRead (internal/stream_base_commons.js:178:27) errno: 'ECONNRESET', code: 'ECONNRESET', syscall: 'read' }
21:36:40     1
21:36:40   ...
@Trott Trott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform. labels Mar 20, 2019
@refack
Copy link
Contributor

refack commented Mar 20, 2019 •
edited
Loading

I have seen this multiple times in the last 48h but it's a flake:
This one failed: https://ci.nodejs.org/job/node-test-commit-windows-fanned/25676/
Resumed and passed: https://ci.nodejs.org/job/node-test-commit-windows-fanned/25687/

specifics:

@refack refack added the inspector Issues and PRs related to the V8 inspector protocol label Mar 20, 2019
@refack
Copy link
Contributor

refack commented Mar 20, 2019

Ping @nodejs/v8-inspector

@Trott Trott changed the title broken test-inspect-async-hook-setup-at-inspect on Windows 2008r2 in CI? investigate flaky test-inspect-async-hook-setup-at-inspect on Windows 2008r2 in CI Mar 21, 2019
@Trott
Copy link
Member Author

Trott commented Mar 21, 2019

https://ci.nodejs.org/job/node-test-binary-windows/24702/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=0/console

test-rackspace-win2008r2-x64-6

00:17:11 not ok 314 parallel/test-inspect-async-hook-setup-at-inspect
00:17:11   ---
00:17:11   duration_ms: 0.614
00:17:11   severity: fail
00:17:11   exitcode: 1
00:17:11   stack: |-
00:17:11     [test] Connecting to a child Node process
00:17:11     [test] Testing /json/list
00:17:11     [err] Debugger listening on ws://127.0.0.1:57632/cfedc474-b361-4187-80ed-1b68bdbd10cd
00:17:11     [err] For help, see: https://nodejs.org/en/docs/inspector
00:17:11     [err] 
00:17:11     [err] Debugger attached.
00:17:11     [err] 
00:17:11     [err] FATAL ERROR: node::inspector::Agent::ToggleAsyncHook Cannot toggle Inspector's AsyncHook, please report this.
00:17:11     [err] 
00:17:11     [err]  1: 000000013F44A0AF napi_wrap+84447
00:17:11     [err]  2: 000000013F4018C6 uv_loop_fork+44166
00:17:11     [err]  3: 000000013F402416 uv_loop_fork+47062
00:17:11     [err]  4: 000000013F401FF9 uv_loop_fork+46009
00:17:11     [err]  5: 000000013F3692C3 std::basic_ios<char,std::char_traits<char> >::imbue+76067
00:17:11     [err] 
00:17:11     [err]  6: 000000013F97F7F7 v8_inspector::protocol::Debugger::API::SearchMatch::fromJSONString+242135
00:17:11     [err]  7: 000000013F95E21C v8_inspector::protocol::Debugger::API::SearchMatch::fromJSONString+105468
00:17:11     [err]  8: 000000013F9478CF v8_inspector::protocol::Debugger::API::SearchMatch::fromJSONString+12975
00:17:11     [err]  9: 000000013F940BCF v8_inspector::protocol::Runtime::API::StackTraceId::fromJSONString+33039
00:17:11     [err] 10: 000000013F9316ED v8::internal::Factory::zero_string+23837
00:17:11     [err] 11: 000000013F735C33 v8_inspector::V8InspectorSession::canDispatchMethod+675
00:17:11     [err] 12: 000000013F369EFA std::basic_ios<char,std::char_traits<char> >::imbue+79194
00:17:11     [err] 13: 000000013F367ED6 std::basic_ios<char,std::char_traits<char> >::imbue+70966
00:17:11     [err] 14: 000000013F357F3E std::basic_ios<char,std::char_traits<char> >::imbue+5534
00:17:11     [err] 15: 000000013F356F9E std::basic_ios<char,std::char_traits<char> >::imbue+1534
00:17:11     [err] 16: 000000013F357ABB std::basic_ios<char,std::char_traits<char> >::imbue+4379
00:17:11     [err] 17: 000000013F3580C7 std::basic_ios<char,std::char_traits<char> >::imbue+5927
00:17:11     [err] 18: 000000013F805035 v8::internal::Isolate::InvalidatePromiseHookProtector+1029
00:17:11     [err] 
00:17:11     [err] 19: 000000013F7E1DEE v8::internal::StackGuard::HandleInterrupts+398
00:17:11     [err] 20: 000000013FAD4985 v8::internal::OptimizingCompileDispatcher::Unblock+53381
00:17:11     [err] 21: 000000013FF6DF1F v8::internal::interpreter::BytecodeRegisterOptimizer::RegisterTransfer+1271791
00:17:11     [err] 
00:17:11     { Error: read ECONNRESET
00:17:11         at TCP.onStreamRead (internal/stream_base_commons.js:182:27) errno: 'ECONNRESET', code: 'ECONNRESET', syscall: 'read' }
00:17:11     1
00:17:11   ...

@refack
Copy link
Contributor

refack commented Mar 21, 2019 •
edited
Loading

Running 100 x python tools\test.py -p tap parallel/test-inspect-async-hook-setup-at-inspect begets:

100   OK: 63   NOT OK: 37   TOTAL: 100

/CC @nodejs/testing @nodejs/n-api

@refack
Copy link
Contributor

refack commented Mar 22, 2019 •
edited
Loading

Bisecting got me to the range of commits that landed on 2019-03-18
between
ed2c696 - https://ci.nodejs.org/job/node-stress-single-test/2176/nodes=win2008r2-vs2017/
a91d36f - https://ci.nodejs.org/job/node-stress-single-test/2179/
and
993bdff - https://ci.nodejs.org/job/node-stress-single-test/2177/nodes=win2008r2-vs2017/

993bdff...a91d36f

I'm off, if anyone want to continue.

@refack refack mentioned this issue Mar 22, 2019
Closed
@refack refack pinned this issue Mar 22, 2019
@refack
Copy link
Contributor

refack commented Mar 22, 2019

pinning this since it has ~50% probability of failing for a CI job.

@joyeecheung joyeecheung mentioned this issue Mar 22, 2019
Closed
@joyeecheung
Copy link
Member

joyeecheung commented Mar 22, 2019 •
edited
Loading

I cannot seem to identify the first CI run this appeared (some historical jobs are cleaned). It might be related to #26602

@joyeecheung
Copy link
Member

We could maybe try using TryCatch when calling into the registered hooks and display the message to have more useful information.

@joyeecheung joyeecheung mentioned this issue Mar 22, 2019
Closed
2 tasks
@joyeecheung
Copy link
Member

Trying to show more information in #26859

@refack
Copy link
Contributor

refack commented Mar 22, 2019

I cannot seem to identify the first CI run this appeared (some historical jobs are cleaned). It might be related to #26602

a91d36f parent commit before #26602 landed (https://ci.nodejs.org/job/node-stress-single-test/2179/) still repros

@joyeecheung
Copy link
Member

joyeecheung commented Mar 22, 2019 •
edited
Loading 

diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
index f14000f626..516c0e48cd 100644
--- a/lib/internal/bootstrap/node.js
+++ b/lib/internal/bootstrap/node.js
@@ -150,6 +150,9 @@ if (isMainThread) {
   setupProcessStdio(getStdout, getStdin, getStderr);
 }

+require('internal/async_hooks');
+// XXX(joyeecheung): this has to be done after the initial load of
+// internal/async_hooks?
 if (config.hasInspector) {
   const {
     enable,

This fixes the test though I have no idea why

@joyeecheung joyeecheung mentioned this issue Mar 22, 2019
Merged
2 tasks
@joyeecheung
Copy link
Member

I opened a fix in #26866 though it's a bit magical..

@Trott
Copy link
Member Author

Trott commented Mar 22, 2019

https://ci.nodejs.org/job/node-test-binary-windows/24778/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=1/console

test-rackspace-win2008r2-x64-5

11:52:06 not ok 314 parallel/test-inspect-async-hook-setup-at-inspect
11:52:06   ---
11:52:06   duration_ms: 0.615
11:52:06   severity: fail
11:52:06   exitcode: 1
11:52:06   stack: |-
11:52:06     [test] Connecting to a child Node process
11:52:06     [test] Testing /json/list
11:52:06     [err] Debugger listening on ws://127.0.0.1:49981/48ed0c36-b59f-4d0c-8606-23323334a3b5
11:52:06     [err] For help, see: https://nodejs.org/en/docs/inspector
11:52:06     [err] 
11:52:06     [err] Debugger attached.
11:52:06     [err] 
11:52:06     [err] FATAL ERROR: node::inspector::Agent::ToggleAsyncHook Cannot toggle Inspector's AsyncHook, please report this.
11:52:06     [err] 
11:52:06     [err]  1: 000000013F8C993F napi_wrap+82655
11:52:06     [err] 
11:52:06     [err]  2: 000000013F881876 uv_loop_fork+44166
11:52:06     [err]  3: 000000013F8823C6 uv_loop_fork+47062
11:52:06     [err]  4: 000000013F881FA9 uv_loop_fork+46009
11:52:06     [err]  5: 000000013F7E92C3 std::basic_ios<char,std::char_traits<char> >::imbue+76067
11:52:06     [err]  6: 000000013FDFF447 v8_inspector::protocol::Debugger::API::SearchMatch::fromJSONString+242135
11:52:06     [err]  7: 000000013FDDDE6C v8_inspector::protocol::Debugger::API::SearchMatch::fromJSONString+105468
11:52:06     [err]  8: 000000013FDC751F v8_inspector::protocol::Debugger::API::SearchMatch::fromJSONString+12975
11:52:06     [err]  9: 000000013FDC081F v8_inspector::protocol::Runtime::API::StackTraceId::fromJSONString+33039
11:52:06     [err] 10: 000000013FDB133D v8::internal::Factory::zero_string+23837
11:52:06     [err] 11: 000000013FBB5663 v8_inspector::V8InspectorSession::canDispatchMethod+675
11:52:06     [err] 12: 000000013F7E9EFA std::basic_ios<char,std::char_traits<char> >::imbue+79194
11:52:06     [err] 13: 000000013F7E7ED6 std::basic_ios<char,std::char_traits<char> >::imbue+70966
11:52:06     [err] 14: 000000013F7D7F3E std::basic_ios<char,std::char_traits<char> >::imbue+5534
11:52:06     [err] 15: 000000013F7D6F9E std::basic_ios<char,std::char_traits<char> >::imbue+1534
11:52:06     [err] 16: 000000013F7D7ABB std::basic_ios<char,std::char_traits<char> >::imbue+4379
11:52:06     [err] 17: 000000013F7D80C7 std::basic_ios<char,std::char_traits<char> >::imbue+5927
11:52:06     [err] 18: 000000013FC84A65 v8::internal::Isolate::InvalidatePromiseHookProtector+1029
11:52:06     [err] 19: 000000013FC6181E v8::internal::StackGuard::HandleInterrupts+398
11:52:06     [err] 20: 000000013FF545D5 v8::internal::OptimizingCompileDispatcher::Unblock+53381
11:52:06     [err] 21: 00000001403EDB6F v8::internal::interpreter::BytecodeRegisterOptimizer::RegisterTransfer+1271791
11:52:06     [err] 
11:52:06     { Error: read ECONNRESET
11:52:06         at TCP.onStreamRead (internal/stream_base_commons.js:182:27) errno: 'ECONNRESET', code: 'ECONNRESET', syscall: 'read' }
11:52:06     1
11:52:06   ...

@Trott
Copy link
Member Author

Trott commented Mar 23, 2019

https://ci.nodejs.org/job/node-test-binary-windows/24791/COMPILED_BY=vs2017,RUNNER=win2008r2-vs2017,RUN_SUBSET=1/console

test-rackspace-win2008r2-x64-3

00:18:42 not ok 314 parallel/test-inspect-async-hook-setup-at-inspect
00:18:42   ---
00:18:42   duration_ms: 0.516
00:18:42   severity: fail
00:18:42   exitcode: 1
00:18:42   stack: |-
00:18:42     [test] Connecting to a child Node process
00:18:42     [test] Testing /json/list
00:18:42     [err] Debugger listening on ws://127.0.0.1:52798/c0a28fb7-706f-4d6f-b310-39e2eac816c6
00:18:42     [err] For help, see: https://nodejs.org/en/docs/inspector
00:18:42     [err] 
00:18:42     [err] Debugger attached.
00:18:42     [err] 
00:18:42     [err] FATAL ERROR: node::inspector::Agent::ToggleAsyncHook Cannot toggle Inspector's AsyncHook, please report this.
00:18:42     [err] 
00:18:42     [err]  1: 000000013F67976F napi_wrap+82655
00:18:42     [err] 
00:18:42     [err]  2: 000000013F631856 uv_loop_fork+44166
00:18:42     [err]  3: 000000013F6323A6 uv_loop_fork+47062
00:18:42     [err]  4: 000000013F631F89 uv_loop_fork+46009
00:18:42     [err]  5: 000000013F5992A3 std::basic_ios<char,std::char_traits<char> >::imbue+76051
00:18:42     [err]  6: 000000013FBAF277 v8_inspector::protocol::Debugger::API::SearchMatch::fromJSONString+242135
00:18:42     [err]  7: 000000013FB8DC9C v8_inspector::protocol::Debugger::API::SearchMatch::fromJSONString+105468
00:18:42     [err]  8: 000000013FB7734F v8_inspector::protocol::Debugger::API::SearchMatch::fromJSONString+12975
00:18:42     [err]  9: 000000013FB7064F v8_inspector::protocol::Runtime::API::StackTraceId::fromJSONString+33039
00:18:42     [err] 10: 000000013FB6116D v8::internal::Factory::zero_string+23837
00:18:42     [err] 11: 000000013F965493 v8_inspector::V8InspectorSession::canDispatchMethod+675
00:18:42     [err] 12: 000000013F599EDA std::basic_ios<char,std::char_traits<char> >::imbue+79178
00:18:42     [err] 13: 000000013F597EB6 std::basic_ios<char,std::char_traits<char> >::imbue+70950
00:18:42     [err] 14: 000000013F587F2E std::basic_ios<char,std::char_traits<char> >::imbue+5534
00:18:42     [err] 
00:18:42     [err] 15: 000000013F586F8E std::basic_ios<char,std::char_traits<char> >::imbue+1534
00:18:42     [err] 16: 000000013F587AAB std::basic_ios<char,std::char_traits<char> >::imbue+4379
00:18:42     [err] 17: 000000013F5880B7 std::basic_ios<char,std::char_traits<char> >::imbue+5927
00:18:42     [err] 18: 000000013FA34895 v8::internal::Isolate::InvalidatePromiseHookProtector+1029
00:18:42     [err] 19: 000000013FA1164E v8::internal::StackGuard::HandleInterrupts+398
00:18:42     [err] 20: 000000013FD04405 v8::internal::OptimizingCompileDispatcher::Unblock+53381
00:18:42     [err] 21: 000000014019D99F v8::internal::interpreter::BytecodeRegisterOptimizer::RegisterTransfer+1271791
00:18:42     [err] 
00:18:42     { Error: read ECONNRESET
00:18:42         at TCP.onStreamRead (internal/stream_base_commons.js:182:27) errno: 'ECONNRESET', code: 'ECONNRESET', syscall: 'read' }
00:18:42     1
00:18:42   ...

refack pushed a commit to joyeecheung/node that referenced this issue Mar 23, 2019
@joyeecheung @refack
process: load internal/async_hooks before inspector hooks registration
0d21299 
Otherwise the exports of `internal/async_hooks` may be undefined
when the inspector async hooks are registered.

PR-URL: nodejs#26866
Fixes: nodejs#26798
Refs: nodejs#26859
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
joyeecheung added a commit to joyeecheung/node that referenced this issue Mar 26, 2019
@joyeecheung
src: do not call into JS in the maxAsyncCallStackDepthChanged interrupt
d5f9395 
If Debugger.setAsyncCallStackDepth is sent during bootstrap,
we cannot immediately call into JS to enable the hooks, which could
interrupt the JS execution of bootstrap. So instead we save the
notification in the inspector agent if it's sent in the middle of
bootstrap, and process the notification later here.

Refs: nodejs#26798
@joyeecheung joyeecheung mentioned this issue Mar 26, 2019
Closed
2 tasks
@joyeecheung
Copy link
Member

FWIW I think I found the real cause, see #26935

targos pushed a commit to targos/node that referenced this issue Mar 27, 2019
@joyeecheung @targos
process: load internal/async_hooks before inspector hooks registration
6e48d8f 
Otherwise the exports of `internal/async_hooks` may be undefined
when the inspector async hooks are registered.

PR-URL: nodejs#26866
Fixes: nodejs#26798
Refs: nodejs#26859
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
targos pushed a commit that referenced this issue Mar 27, 2019
@joyeecheung @targos
process: load internal/async_hooks before inspector hooks registration
41761cc 
Otherwise the exports of `internal/async_hooks` may be undefined
when the inspector async hooks are registered.

PR-URL: #26866
Fixes: #26798
Refs: #26859
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
joyeecheung added a commit that referenced this issue Mar 30, 2019
@joyeecheung
src: do not call into JS in the maxAsyncCallStackDepthChanged interrupt
7aad63b 
If Debugger.setAsyncCallStackDepth is sent during bootstrap,
we cannot immediately call into JS to enable the hooks, which could
interrupt the JS execution of bootstrap. So instead we save the
notification in the inspector agent if it's sent in the middle of
bootstrap, and process the notification later here.

Refs: #26798

PR-URL: #26935
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@richardlau richardlau unpinned this issue Mar 30, 2019
pull bot pushed a commit to zys-contrib/node that referenced this issue Mar 30, 2019
@joyeecheung
inspector: display error when ToggleAsyncHook fails
61ef9df 
This patch refactors `AppendExceptionLine` and `PrintSyncTrace`
to reuse the error formatting logic and use them to print
uncaught error in ``ToggleAsyncHook`

PR-URL: nodejs#26859
Refs: nodejs#26798
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@joyeecheung joyeecheung mentioned this issue Mar 31, 2019
Closed
2 tasks
BethGriggs pushed a commit that referenced this issue Apr 5, 2019
@joyeecheung @BethGriggs
src: do not call into JS in the maxAsyncCallStackDepthChanged interrupt
4e1fe29 
If Debugger.setAsyncCallStackDepth is sent during bootstrap,
we cannot immediately call into JS to enable the hooks, which could
interrupt the JS execution of bootstrap. So instead we save the
notification in the inspector agent if it's sent in the middle of
bootstrap, and process the notification later here.

Refs: #26798

PR-URL: #26935
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
BethGriggs pushed a commit that referenced this issue Apr 5, 2019
@joyeecheung @BethGriggs
inspector: display error when ToggleAsyncHook fails
0db74d1 
This patch refactors `AppendExceptionLine` and `PrintSyncTrace`
to reuse the error formatting logic and use them to print
uncaught error in ``ToggleAsyncHook`

PR-URL: #26859
Refs: #26798
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BethGriggs pushed a commit that referenced this issue Apr 8, 2019
@joyeecheung @BethGriggs
src: do not call into JS in the maxAsyncCallStackDepthChanged interrupt
e776b01 
If Debugger.setAsyncCallStackDepth is sent during bootstrap,
we cannot immediately call into JS to enable the hooks, which could
interrupt the JS execution of bootstrap. So instead we save the
notification in the inspector agent if it's sent in the middle of
bootstrap, and process the notification later here.

Refs: #26798

PR-URL: #26935
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this issue Apr 8, 2019
@joyeecheung @BethGriggs
inspector: display error when ToggleAsyncHook fails
760d089 
This patch refactors `AppendExceptionLine` and `PrintSyncTrace`
to reuse the error formatting logic and use them to print
uncaught error in ``ToggleAsyncHook`

PR-URL: #26859
Refs: #26798
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@edopalmieri
Copy link

edopalmieri commented Apr 9, 2019 •
edited
Loading

Not sure if this is 100% related but I kept getting this on version: 11.13.0.
I get no error when reverting back to 10.15.3. I am on Mac OSX 10.14.4.

undefined:0


illegal access
Waiting for the debugger to disconnect...
FATAL ERROR: node::inspector::Agent::ToggleAsyncHook Cannot toggle Inspector's AsyncHook, please report this.
 1: 0x10006778e node::Abort() [/usr/local/bin/node]
 2: 0x100067ede node::errors::TryCatchScope::~TryCatchScope() [/usr/local/bin/node]
 3: 0x100067d70 node::OnFatalError(char const*, char const*) [/usr/local/bin/node]
 4: 0x100102e9b node::inspector::Agent::ToggleAsyncHook(v8::Isolate*, v8::Persistent<v8::Function, node::ResetInDestructorPersistentTraits<v8::Function> > const&) [/usr/local/bin/node]
 5: 0x100178703 v8_inspector::V8Debugger::setAsyncCallStackDepth(v8_inspector::V8DebuggerAgentImpl*, int) [/usr/local/bin/node]
 6: 0x100180de7 v8_inspector::V8DebuggerAgentImpl::disable() [/usr/local/bin/node]
 7: 0x100199733 v8_inspector::V8InspectorSessionImpl::~V8InspectorSessionImpl() [/usr/local/bin/node]
 8: 0x1001999de v8_inspector::V8InspectorSessionImpl::~V8InspectorSessionImpl() [/usr/local/bin/node]
 9: 0x1001039e0 node::inspector::(anonymous namespace)::ChannelImpl::~ChannelImpl() [/usr/local/bin/node]
10: 0x100103a3a node::inspector::(anonymous namespace)::ChannelImpl::~ChannelImpl() [/usr/local/bin/node]
11: 0x100103e1e node::inspector::NodeInspectorClient::disconnectFrontend(int) [/usr/local/bin/node]
12: 0x100103c55 node::inspector::(anonymous namespace)::SameThreadInspectorSession::~SameThreadInspectorSession() [/usr/local/bin/node]
13: 0x100103c82 node::inspector::(anonymous namespace)::SameThreadInspectorSession::~SameThreadInspectorSession() [/usr/local/bin/node]
14: 0x10011064c node::inspector::(anonymous namespace)::DeletableWrapper<node::inspector::(anonymous namespace)::MainThreadSessionState>::~DeletableWrapper() [/usr/local/bin/node]
15: 0x100110670 node::inspector::(anonymous namespace)::DeletableWrapper<node::inspector::(anonymous namespace)::MainThreadSessionState>::~DeletableWrapper() [/usr/local/bin/node]
16: 0x10011179b std::__1::__hash_table<std::__1::__hash_value_type<int, std::__1::unique_ptr<node::inspector::Deletable, std::__1::default_delete<node::inspector::Deletable> > >, std::__1::__unordered_map_hasher<int, std::__1::__hash_value_type<int, std::__1::unique_ptr<node::inspector::Deletable, std::__1::default_delete<node::inspector::Deletable> > >, std::__1::hash<int>, true>, std::__1::__unordered_map_equal<int, std::__1::__hash_value_type<int, std::__1::unique_ptr<node::inspector::Deletable, std::__1::default_delete<node::inspector::Deletable> > >, std::__1::equal_to<int>, true>, std::__1::allocator<std::__1::__hash_value_type<int, std::__1::unique_ptr<node::inspector::Deletable, std::__1::default_delete<node::inspector::Deletable> > > > >::erase(std::__1::__hash_const_iterator<std::__1::__hash_node<std::__1::__hash_value_type<int, std::__1::unique_ptr<node::inspector::Deletable, std::__1::default_delete<node::inspector::Deletable> > >, void*>*>) [/usr/local/bin/node]
17: 0x1001116c2 unsigned long std::__1::__hash_table<std::__1::__hash_value_type<int, std::__1::unique_ptr<node::inspector::Deletable, std::__1::default_delete<node::inspector::Deletable> > >, std::__1::__unordered_map_hasher<int, std::__1::__hash_value_type<int, std::__1::unique_ptr<node::inspector::Deletable, std::__1::default_delete<node::inspector::Deletable> > >, std::__1::hash<int>, true>, std::__1::__unordered_map_equal<int, std::__1::__hash_value_type<int, std::__1::unique_ptr<node::inspector::Deletable, std::__1::default_delete<node::inspector::Deletable> > >, std::__1::equal_to<int>, true>, std::__1::allocator<std::__1::__hash_value_type<int, std::__1::unique_ptr<node::inspector::Deletable, std::__1::default_delete<node::inspector::Deletable> > > > >::__erase_unique<int>(int const&) [/usr/local/bin/node]
18: 0x10010fc49 node::inspector::MainThreadInterface::RemoveObject(int) [/usr/local/bin/node]
19: 0x10010f84d node::inspector::MainThreadInterface::DispatchMessages() [/usr/local/bin/node]
20: 0x1000c0fb6 node::PerIsolatePlatformData::RunForegroundTask(std::__1::unique_ptr<v8::Task, std::__1::default_delete<v8::Task> >) [/usr/local/bin/node]
21: 0x1000c0536 node::PerIsolatePlatformData::FlushForegroundTasksInternal() [/usr/local/bin/node]
22: 0x1000c1417 node::NodePlatform::FlushForegroundTasks(v8::Isolate*) [/usr/local/bin/node]
23: 0x1001034a9 node::inspector::NodeInspectorClient::runMessageLoop() [/usr/local/bin/node]
24: 0x1000dadc3 std::__1::__function::__func<node::worker::Worker::Run()::$_0, std::__1::allocator<node::worker::Worker::Run()::$_0>, void ()>::operator()() [/usr/local/bin/node]
25: 0x10007ea5f node::OnScopeLeave::~OnScopeLeave() [/usr/local/bin/node]
26: 0x1000d88ba node::worker::Worker::Run() [/usr/local/bin/node]
27: 0x1000da547 node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_2::__invoke(void*) [/usr/local/bin/node]
28: 0x7fff69c1f305 _pthread_body [/usr/lib/system/libsystem_pthread.dylib]
29: 0x7fff69c2226f _pthread_start [/usr/lib/system/libsystem_pthread.dylib]
30: 0x7fff69c1e415 thread_start [/usr/lib/system/libsystem_pthread.dylib]

@edopalmieri edopalmieri mentioned this issue Apr 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. inspector Issues and PRs related to the V8 inspector protocol windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

process: load internal/async_hooks before inspector hooks registration joyeecheung/node
4 participants
@refack @Trott @joyeecheung @edopalmieri