v8.deserialize triggers Buffer constructor deprecation warning

[Conduitry]

• Version: Observed on 10.4.0, presumably occurs on all 10+
• Platform: All

Deserializing a representation of an expression that contained a Buffer displays(node:15176) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

Reproduce withv8.deserialize(v8.serialize(Buffer.alloc(0))).

It looks like DefaultDeserializer ._readHostObject() needs a special case for buffers.

[Trott]

@nodejs/v8 @nodejs/buffer

[ryzokuken]

@Conduitry line to be blamed for this:

node/lib/v8.js

Line 189 in c9d9bf1

return new ctor(this.buffer.buffer,

/cc @nodejs/buffer @ChALkeR do we break character and hide the warning? I hope not. There's got to be a way to achieve the same functionality without using the Buffer constructor.

[addaleax]

Like this? :)

diff --git a/lib/v8.js b/lib/v8.js
index ed93b094ca78..0d9ffc6033ce 100644
--- a/lib/v8.js
+++ b/lib/v8.js
@@ -144,5 +144,5 @@ const arrayBufferViewTypeToIndex = new Map();
 }
 
-const bufferConstructorIndex = arrayBufferViewTypes.push(Buffer) - 1;
+const bufferConstructorIndex = arrayBufferViewTypes.push(FastBuffer) - 1;
 
 class DefaultSerializer extends Serializer {

[ryzokuken]

@addaleax we have a drop-in, secure replacement for Buffer? I didn't know. Will make a patch.

[addaleax]

@ryzokuken It’s not really drop-in because it only takes Uint8Array-style arguments, but that’s not an issue here, right?

[ryzokuken]

Exactly. The arguments are literally being passed into an Uint8Array, so that's definitely not a problem.

[Conduitry]

This looks good now in 10.5.0 👍