Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: investigate flaky test-child-process-send-returns-boolean #15176

Closed
refack opened this issue Sep 4, 2017 · 5 comments · Fixed by #15186
Closed

test: investigate flaky test-child-process-send-returns-boolean #15176

refack opened this issue Sep 4, 2017 · 5 comments · Fixed by #15186
Labels
child_process Issues and PRs related to the child_process subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.

Comments

@refack
Copy link
Contributor

refack commented Sep 4, 2017

  • Version: b24e269
  • Platform: Windows
  • Subsystem: test,child_process

https://ci.nodejs.org/job/node-test-binary-windows/10905/RUN_SUBSET=0,VS_VERSION=vs2015-x86,label=win2008r2

not ok 46 parallel/test-child-process-send-returns-boolean
  ---
  duration_ms: 0.501
  severity: fail
  stack: |-
    events.js:182
          throw er; // Unhandled 'error' event
          ^
    
    Error: write EMFILE
        at _errnoException (util.js:1027:13)
        at ChildProcess.target._send (internal/child_process.js:721:20)
        at ChildProcess.<anonymous> (internal/child_process.js:550:16)
        at emitTwo (events.js:125:13)
        at ChildProcess.emit (events.js:213:7)
        at emit (internal/child_process.js:791:12)
        at _combinedTickCallback (internal/process/next_tick.js:141:11)
        at process._tickCallback (internal/process/next_tick.js:180:9)
  ...
@refack refack added child_process Issues and PRs related to the child_process subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform. labels Sep 4, 2017
@refack
Copy link
Contributor Author

refack commented Sep 4, 2017

@targos
Copy link
Member

targos commented Sep 4, 2017

@refack: Not building v9 on Windows 2008R2 with VS2013 as it is only supported up to v5.x

@refack
Copy link
Contributor Author

refack commented Sep 4, 2017

@refack: Not building v9 on Windows 2008R2 with VS2013 as it is only supported up to v5.x

😢

I'll try again

@refack
Copy link
Contributor Author

refack commented Sep 4, 2017

@refack
Copy link
Contributor Author

refack commented Sep 4, 2017

The test uses the empty.js fixture to run as a subprocess. If it exits too soon, we get EMFILE.

19   OK: 19   NOT OK: 0   TOTAL: 100
TAP version 13
1..6
ok 1 parallel/test-child-process-send-after-close
  ---
  duration_ms: 0.623
  ...
ok 2 parallel/test-child-process-send-cb
  ---
  duration_ms: 0.625
  ...
ok 3 parallel/test-child-process-send-keep-open
  ---
  duration_ms: 0.624
  ...
ok 4 parallel/test-child-process-send-type-error
  ---
  duration_ms: 0.621
  ...
not ok 5 parallel/test-child-process-send-returns-boolean
  ---
  duration_ms: 0.624
  severity: fail
  stack: |-
    events.js:182
          throw er; // Unhandled 'error' event
          ^
    
    Error: write EMFILE
        at _errnoException (util.js:1027:13)
        at ChildProcess.target._send (internal/child_process.js:721:20)
        at ChildProcess.<anonymous> (internal/child_process.js:550:16)
        at emitTwo (events.js:125:13)
        at ChildProcess.emit (events.js:213:7)
        at emit (internal/child_process.js:791:12)
        at _combinedTickCallback (internal/process/next_tick.js:141:11)
        at process._tickCallback (internal/process/next_tick.js:180:9)
  ...
ok 6 parallel/test-child-process-send-utf8
  ---
  duration_ms: 0.624
  ...
20   OK: 19   NOT OK: 1   TOTAL: 100

PR in the works

refack added a commit to refack/node that referenced this issue Sep 11, 2017
* Add multiple comments.
* Switch to a persistent fixture for subprocess.
* Assert that `send` queue is drained.

PR-URL: nodejs#15186
Fixes: nodejs#15176
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this issue Sep 13, 2017
* Add multiple comments.
* Switch to a persistent fixture for subprocess.
* Assert that `send` queue is drained.

PR-URL: nodejs#15186
Fixes: nodejs#15176
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this issue Sep 20, 2017
* Add multiple comments.
* Switch to a persistent fixture for subprocess.
* Assert that `send` queue is drained.

PR-URL: #15186
Fixes: #15176
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants