Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failed test: sequential/test-signal-unregister #1223

Closed
jbergstroem opened this issue Mar 20, 2015 · 1 comment
Closed

failed test: sequential/test-signal-unregister #1223

jbergstroem opened this issue Mar 20, 2015 · 1 comment
Labels
test Issues and PRs related to the tests.

Comments

@jbergstroem
Copy link
Member

I've seen this show up on the iojs-ubuntu1410-64 slave every now and then:

=== release test-signal-unregister ===
Path: sequential/test-signal-unregister
Sending SIGINT
Chance has been given to die
Child did not die on SIGINT, sending SIGTERM
assert.js:87
  throw new assert.AssertionError({
        ^
AssertionError: false == true
    at process.<anonymous> (/home/iojs/build/workspace/iojs+any-pr+multi/nodes/iojs-ubuntu1410-64/test/sequential/test-signal-unregister.js:31:10)
    at emitOne (events.js:82:20)
    at process.emit (events.js:166:7)
Command: out/Release/iojs /home/iojs/build/workspace/iojs+any-pr+multi/nodes/iojs-ubuntu1410-64/test/sequential/test-signal-unregister.js

Guessing bumping the timeout would make it go away. Not sure if that's what we want though.
@jbergstroem jbergstroem added the test Issues and PRs related to the tests. label Mar 20, 2015
@bnoordhuis bnoordhuis mentioned this issue Mar 21, 2015
Merged
bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Mar 22, 2015
@bnoordhuis
test: fix timing issue in signal test
10a9c00 
Change sequential/test-signal-unregister so it doesn't use fixed
timeouts for sending the signal and expecting the child to quit.

Fixes: nodejs#1223
PR-URL: nodejs#1227
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@brendanashworth
Copy link
Contributor

Can this be closed?

@richardlau richardlau mentioned this issue Jun 6, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbergstroem @Fishrock123 @brendanashworth