Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm benchmarks are broken #11895

Closed
targos opened this issue Mar 17, 2017 · 2 comments
Closed

vm benchmarks are broken #11895

targos opened this issue Mar 17, 2017 · 2 comments
Labels
benchmark Issues and PRs related to the benchmark subsystem. good first issue Issues that are suitable for first-time contributors.

Comments

@targos
Copy link
Member

targos commented Mar 17, 2017

In #9615 common.v8ForceOptimization was removed along with most of the calls to it.
The vm benchmarks were added after the creation of the PR and they were forgotten.
@targos targos added benchmark Issues and PRs related to the benchmark subsystem. good first issue Issues that are suitable for first-time contributors. labels Mar 17, 2017
@TimothyGu
Copy link
Member

Also applies to url/whatwg-url-idna.js

lucaslago added a commit to lucaslago/node that referenced this issue Mar 17, 2017
@lucaslago
benchmark: remove v8ForceOptimization calls
cda921e 
This removes common.v8ForceOptimization calls from url and vm benchmark
files.

Fixes: nodejs#11895
@lucaslago lucaslago mentioned this issue Mar 17, 2017
Closed
3 tasks
targos pushed a commit to targos/node that referenced this issue Mar 21, 2017
@lucaslago @targos
benchmark: remove v8ForceOptimization calls
3129ba2 
This removes common.v8ForceOptimization calls from url and vm benchmark
files.

PR-URL: nodejs#11908
Fixes: nodejs#11895
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos
Copy link
Member Author

targos commented Mar 21, 2017

Fixed in 3129ba2

@targos targos closed this as completed Mar 21, 2017
jungx098 pushed a commit to jungx098/node that referenced this issue Mar 21, 2017
@lucaslago @jungx098
benchmark: remove v8ForceOptimization calls
4bff6b8 
This removes common.v8ForceOptimization calls from url and vm benchmark
files.

PR-URL: nodejs#11908
Fixes: nodejs#11895
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this issue Mar 28, 2017
@lucaslago @MylesBorins
benchmark: remove v8ForceOptimization calls
85eb1bc 
This removes common.v8ForceOptimization calls from url and vm benchmark
files.

PR-URL: #11908
Fixes: #11895
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. good first issue Issues that are suitable for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

benchmark: remove v8ForceOptimization calls lucaslago/node
2 participants
@TimothyGu @targos