Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: watch WHATWG URL issue #217 (file state clarification) #10978

Closed
jasnell opened this issue Jan 24, 2017 · 0 comments
Closed

url: watch WHATWG URL issue #217 (file state clarification) #10978

jasnell opened this issue Jan 24, 2017 · 0 comments
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.

Comments

@jasnell
Copy link
Member

jasnell commented Jan 24, 2017

WHATWG URL issue whatwg/url#217 deals with a clarification/fix that is needed for parsing file URL's like file:#foo and file:?bar. The current parse results are incorrect.
@jasnell jasnell added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jan 24, 2017
@watilde watilde mentioned this issue Feb 2, 2017
Closed
3 tasks
watilde added a commit to watilde/node that referenced this issue Feb 13, 2017
@watilde
url: fix file state clarification in binding
a723caa 
The state of query and fragment in file state
clarification should be adjusted after the state of
the path is confirmed.

Applicable cases:
+ `file:#foo` => `file:///#foo`
+ `file:?bar` => `file:///?bar`

Fixes: nodejs#10978
jasnell pushed a commit that referenced this issue Feb 17, 2017
@watilde @jasnell
url, test: synchronize WPT url tests for file URL
4577775 
Added at the following PR:
* web-platform-tests/wpt#4382
* web-platform-tests/wpt#4700

PR-URL: #11123
Fixes: #10978
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this issue Feb 20, 2017
@watilde @italoacasas
url: fix file state clarification in binding
1a70f6c 
An empty file URL `file:` should be parsed to `file:///` instead of
`file://`. In the `kFile` state, the process was braked immediately
when the ch is EOL, but it should work as `default` in the kFile state
to adjust slashes.

Applicable cases:
* `file:#foo` => `file:///#foo`
* `file:?bar` => `file:///?bar`

PR-URL: nodejs#11123
Fixes: nodejs#10978
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this issue Feb 20, 2017
@watilde @italoacasas
url, test: synchronize WPT url tests for file URL
f189623 
Added at the following PR:
* web-platform-tests/wpt#4382
* web-platform-tests/wpt#4700

PR-URL: nodejs#11123
Fixes: nodejs#10978
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
italoacasas pushed a commit that referenced this issue Feb 22, 2017
@watilde @italoacasas
url: fix file state clarification in binding
72da362 
An empty file URL `file:` should be parsed to `file:///` instead of
`file://`. In the `kFile` state, the process was braked immediately
when the ch is EOL, but it should work as `default` in the kFile state
to adjust slashes.

Applicable cases:
* `file:#foo` => `file:///#foo`
* `file:?bar` => `file:///?bar`

PR-URL: #11123
Fixes: #10978
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
italoacasas pushed a commit that referenced this issue Feb 22, 2017
@watilde @italoacasas
url, test: synchronize WPT url tests for file URL
d8cb65a 
Added at the following PR:
* web-platform-tests/wpt#4382
* web-platform-tests/wpt#4700

PR-URL: #11123
Fixes: #10978
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasnell