Skip to content

Commit

Permalink
test: add tests for add/remove header after sent
Browse files Browse the repository at this point in the history
This change adds tests to make sure an Error is thrown if a header
is added or removed after they are sent.

PR-URL: #8682
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
  • Loading branch information
niklasi authored and MylesBorins committed Oct 26, 2016
1 parent e79351c commit f46a04c
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 0 deletions.
21 changes: 21 additions & 0 deletions test/parallel/test-http-response-add-header-after-sent.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
'use strict';
require('../common');
const assert = require('assert');
const http = require('http');

const server = http.createServer((req, res) => {
assert.doesNotThrow(() => {
res.setHeader('header1', 1);
});
res.write('abc');
assert.throws(() => {
res.setHeader('header2', 2);
}, /Can't set headers after they are sent\./);
res.end();
});

server.listen(0, () => {
http.get({port: server.address().port}, () => {
server.close();
});
});
21 changes: 21 additions & 0 deletions test/parallel/test-http-response-remove-header-after-sent.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
'use strict';
require('../common');
const assert = require('assert');
const http = require('http');

const server = http.createServer((req, res) => {
assert.doesNotThrow(() => {
res.removeHeader('header1', 1);
});
res.write('abc');
assert.throws(() => {
res.removeHeader('header2', 2);
}, /Can't remove headers after they are sent/);
res.end();
});

server.listen(0, () => {
http.get({port: server.address().port}, () => {
server.close();
});
});

0 comments on commit f46a04c

Please sign in to comment.