Skip to content

Commit

Permalink
build: fix cctest target for --without-report
Browse files Browse the repository at this point in the history
Conditionally build `test/cctest/test_report_util.cc` only when
configured to include the diagnostic report feature.

PR-URL: #28238
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
richardlau authored and targos committed Jun 18, 2019
1 parent b6f113b commit ddef3d0
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion node.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -1096,7 +1096,6 @@
'test/cctest/test_linked_binding.cc',
'test/cctest/test_per_process.cc',
'test/cctest/test_platform.cc',
'test/cctest/test_report_util.cc',
'test/cctest/test_traced_value.cc',
'test/cctest/test_util.cc',
'test/cctest/test_url.cc',
Expand Down Expand Up @@ -1134,6 +1133,9 @@
},
}],
[ 'node_report=="true"', {
'sources': [
'test/cctest/test_report_util.cc',
],
'defines': [
'NODE_REPORT',
'NODE_ARCH="<(target_arch)"',
Expand Down

0 comments on commit ddef3d0

Please sign in to comment.