Skip to content

Commit

Permalink
fixup! doc: document considerations for inclusion in core
Browse files Browse the repository at this point in the history
  • Loading branch information
Trott committed Oct 20, 2021
1 parent 90d7fb2 commit c5e35ad
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions doc/guides/modules-in-core.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,12 @@ not.
2. The module can only be implemented in core.
3. The module can only be implemented in a performant way in core.
4. Developer experience is significantly improved if the module is in core.
5. The module will be widely used, have cross platform native code, and being in
core will avoid the need for an end-user compilation chain.
6. Part or all of the module will also be re-used or duplicated in core.
5. The module provides functionality that can be expected to solve at least one
common use case Node.js users face.
6. The module requires native bindings. Inclusion in core enables utility across
operating systems and architectures without requiring users to have a native
compilation toolchain.
7. Part or all of the module will also be re-used or duplicated in core.

## Strong arguments against including a module in core

Expand Down

0 comments on commit c5e35ad

Please sign in to comment.