Skip to content

Commit

Permalink
test: use assert.throws() in test-require-json.js
Browse files Browse the repository at this point in the history
Use assert.throws() instead of try/catch.

PR-URL: #28358
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
alejandronanez authored and targos committed Aug 2, 2019
1 parent 3e63429 commit b6e174b
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions test/parallel/test-require-json.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,9 @@ require('../common');
const assert = require('assert');
const fixtures = require('../common/fixtures');

try {
assert.throws(function() {
require(fixtures.path('invalid.json'));
} catch (err) {
assert.ok(
/test[/\\]fixtures[/\\]invalid\.json: /.test(err.message),
`require() json error should include path: ${err.message}`);
}
}, {
name: 'SyntaxError',
message: /test[/\\]fixtures[/\\]invalid\.json: /,
});

0 comments on commit b6e174b

Please sign in to comment.