Skip to content

Commit

Permalink
doc: use NODE_API_SUPPORTED_VERSION_MAX in release doc
Browse files Browse the repository at this point in the history
The code was changed in #48501 but the doc was missed.
  • Loading branch information
zcbenz committed Aug 21, 2023
1 parent de4553f commit af600f9
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions doc/contributing/releases-node-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ release process.
* [0. Pre-release steps](#0-pre-release-steps)
* [1. Update the main branch](#1-update-the-main-branch)
* [2. Create a new branch for the release](#2-create-a-new-branch-for-the-release)
* [3. Update `NAPI_VERSION`](#3-update-napi_version)
* [3. Update `NODE_API_SUPPORTED_VERSION_MAX`](#3-update-node_api_supported_version_max)
* [4. Define `addon_context_register_func`](#4-define-addon_context_register_func)
* [5. Update version guards](#5-update-version-guards)
* [6. Create release commit](#6-create-release-commit)
Expand Down Expand Up @@ -55,13 +55,13 @@ Create a new branch named `node-api-x-proposal`, off the main branch.
git checkout -b node-api-10-proposal upstream/main
```

### 3. Update `NAPI_VERSION`
### 3. Update `NODE_API_SUPPORTED_VERSION_MAX`

Set the version for the proposed release using the following macros, which are
already defined in `src/node_version.h`:

```c
#define NAPI_VERSION x
#define NODE_API_SUPPORTED_VERSION_MAX x
```
> Note: Do not update the `NAPI_VERSION` defined in `src/js_native_api.h`. It
Expand Down

0 comments on commit af600f9

Please sign in to comment.