tools: lint for unused catch bindings

PR-URL: #24079 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Wyatt Preul <wpreul@gmail.com>
nodejs · Dec 3, 2018 · a67e04e · a67e04e
1 parent eed47b0
commit a67e04e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -17,7 +17,7 @@ Module._findPath = (request, paths, isMain) => {
   if (!r && hacks.includes(request)) {
     try {
       return require.resolve(`./tools/node_modules/${request}`);
-    } catch (err) {
+    } catch {
       return require.resolve(
         `./tools/node_modules/eslint/node_modules/${request}`);
     }
@@ -212,7 +212,7 @@ module.exports = {
     'no-unsafe-finally': 'error',
     'no-unsafe-negation': 'error',
     'no-unused-labels': 'error',
-    'no-unused-vars': ['error', { args: 'none' }],
+    'no-unused-vars': ['error', { args: 'none', caughtErrors: 'all' }],
     'no-use-before-define': ['error', {
       classes: true,
       functions: false,

diff --git a/lib/buffer.js b/lib/buffer.js
@@ -42,7 +42,7 @@ const {
 let isAnyArrayBuffer;
 try {
   isAnyArrayBuffer = internalBinding('types').isAnyArrayBuffer;
-} catch (e) {
+} catch {
   isAnyArrayBuffer = require('util').types.isAnyArrayBuffer;
 }
 const {

diff --git a/lib/stream.js b/lib/stream.js
@@ -51,7 +51,7 @@ try {
     // returns undefined for Node < 7.4.0.
     Stream._isUint8Array = process.binding('util').isUint8Array;
   }
-} catch (e) {
+} catch (e) { // eslint-disable-line no-unused-vars
 }
 
 if (!Stream._isUint8Array) {
@@ -71,7 +71,7 @@ if (version[0] === 0 && version[1] < 12) {
                                            chunk.byteOffset,
                                            chunk.byteLength);
     };
-  } catch (e) {
+  } catch (e) { // eslint-disable-line no-unused-vars
   }
 
   if (!Stream._uint8ArrayToBuffer) {