Update based on comments

nodejs · May 15, 2019 · a59024b · a59024b
1 parent f92f828
commit a59024b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/node_file.h b/src/node_file.h
@@ -162,7 +162,7 @@ template <typename NativeT,
 constexpr NativeT ToNative(uv_timespec_t ts) {
   // This template has exactly two specializations below.
   static_assert(std::is_arithmetic<NativeT>::value == false, "Not implemented");
-  UNREACHABLE();
+  return NativeT();
 }
 
 template <>

diff --git a/src/util.h b/src/util.h
@@ -120,7 +120,7 @@ void DumpBacktrace(FILE* fp);
   do {                                                                        \
     /* Make sure that this struct does not end up in inline code, but      */ \
     /* rather in a read-only data section when modifying this code.        */ \
-    const node::AssertionInfo args = {                                        \
+    static const node::AssertionInfo args = {                                 \
       __FILE__ ":" STRINGIFY(__LINE__), #expr, PRETTY_FUNCTION_NAME           \
     };                                                                        \
     node::Assert(args);                                                       \