Skip to content

Commit

Permalink
[suggestion] flipped if and skip jslint
Browse files Browse the repository at this point in the history
  • Loading branch information
refack committed Aug 22, 2017
1 parent c9ef989 commit a159bfa
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions vcbuild.bat
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ if /i "%1"=="download-all" set download_arg="--download=all"&goto arg-ok
if /i "%1"=="ignore-flaky" set test_args=%test_args% --flaky-tests=dontcare&goto arg-ok
if /i "%1"=="enable-vtune" set enable_vtune_arg=1&goto arg-ok
if /i "%1"=="dll" set dll=1&goto arg-ok
if /i "%1"=="static" set enable_static=1&goto arg-ok
if /i "%1"=="static" set enable_static=1&goto arg-ok
if /i "%1"=="no-NODE-OPTIONS" set no_NODE_OPTIONS=1&goto arg-ok
if /i "%1"=="debug-http2" set debug_http2=1&goto arg-ok
if /i "%1"=="debug-nghttp2" set debug_nghttp2=1&goto arg-ok
Expand Down Expand Up @@ -445,10 +445,10 @@ if "%config%"=="Debug" set test_args=--mode=debug %test_args%
if "%config%"=="Release" set test_args=--mode=release %test_args%
echo running 'cctest %cctest_args%'
"%config%\cctest" %cctest_args%
if not defined enable_static (
call :run-python tools\test.py %test_args%
goto test-v8
)
REM when building a static library there's no binary to run tests
if defined enable_static goto test-v8
call :run-python tools\test.py %test_args%

:test-v8
if not defined custom_v8_test goto cpplint
call tools/test-v8.bat
Expand Down Expand Up @@ -495,6 +495,7 @@ set "localcppfilelist=%localcppfilelist% %1"
goto exit

:jslint
if defined enable_static goto exit
if defined jslint_ci goto jslint-ci
if not defined jslint goto exit
if not exist tools\eslint\bin\eslint.js goto no-lint
Expand Down

0 comments on commit a159bfa

Please sign in to comment.