Skip to content

Commit

Permalink
src: remove extra ReadStop() call
Browse files Browse the repository at this point in the history
This is no longer necessary since libuv 1.21.0.

PR-URL: #21528
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
addaleax committed Jun 30, 2018
1 parent deff8db commit a078521
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
5 changes: 0 additions & 5 deletions src/stream_wrap.cc
Original file line number Diff line number Diff line change
Expand Up @@ -373,11 +373,6 @@ void LibuvStreamWrap::AfterUvWrite(uv_write_t* req, int status) {
req_wrap->Done(status);
}

void LibuvStreamWrap::Close(v8::Local<v8::Value> close_callback) {
ReadStop();
HandleWrap::Close(close_callback);
}

} // namespace node

NODE_BUILTIN_MODULE_CONTEXT_AWARE(stream_wrap,
Expand Down
2 changes: 0 additions & 2 deletions src/stream_wrap.h
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,6 @@ class LibuvStreamWrap : public HandleWrap, public StreamBase {
ShutdownWrap* CreateShutdownWrap(v8::Local<v8::Object> object) override;
WriteWrap* CreateWriteWrap(v8::Local<v8::Object> object) override;

void Close(v8::Local<v8::Value> close_callback) override;

protected:
LibuvStreamWrap(Environment* env,
v8::Local<v8::Object> object,
Expand Down

0 comments on commit a078521

Please sign in to comment.