Skip to content

Commit

Permalink
doc: add note regarding pushing release tags
Browse files Browse the repository at this point in the history
Tags shouldn't be pushed unless the remainder of release steps are able
to be completed.

PR-URL: #25569
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
MylesBorins committed Jan 24, 2019
1 parent a9ffce9 commit 9d8a225
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions doc/releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,9 @@ following command:
$ git push <remote> <vx.y.z>
```

*Note*: Please do not push the tag unless you are ready to complete the
remainder of the release steps.

### 12. Set Up For the Next Release

On release proposal branch, edit `src/node_version.h` again and:
Expand Down

0 comments on commit 9d8a225

Please sign in to comment.