Skip to content

Commit

Permalink
build: enable ASLR (PIE) on OS X
Browse files Browse the repository at this point in the history
After conducting several benchmarks, I noticed performance losses of
5-10%. As OS X is not a performance critical platform, as already
mentioned by @bnoordhuis, I have removed the -no_pie flag at least for
this platform. I'd love to enable PIE for other platforms if the 5-10%
speed loss is not too high. I would be happy to hear your opinion on
this.

Refs: #33425

PR-URL: #35704
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
  • Loading branch information
woodfairy authored and nodejs-github-bot committed Nov 17, 2020
1 parent fff25a0 commit 8d6b74d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -495,8 +495,7 @@
['_type!="static_library"', {
'xcode_settings': {
'OTHER_LDFLAGS': [
'-Wl,-no_pie',
'-Wl,-search_paths_first',
'-Wl,-search_paths_first'
],
},
}],
Expand Down

0 comments on commit 8d6b74d

Please sign in to comment.