-
Notifications
You must be signed in to change notification settings - Fork 29.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix --prof-process --preprocess flag
This is a one-line fix to prevent the --preprocess option (used with --prof-process to output JSON) to cause an isolate log file profiling process to crash. PR-URL: #14966 Reviewed-By: Luca Maraschi <luca.maraschi@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
- Loading branch information
Showing
3 changed files
with
29 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
test/tick-processor/test-tick-processor-preprocess-flag.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
'use strict'; | ||
const common = require('../common'); | ||
|
||
if (!common.enoughTestCpu) | ||
common.skip('test is CPU-intensive'); | ||
|
||
if (common.isWindows || | ||
common.isSunOS || | ||
common.isAIX || | ||
common.isLinuxPPCBE || | ||
common.isFreeBSD) | ||
common.skip('C++ symbols are not mapped for this os.'); | ||
|
||
const base = require('./tick-processor-base.js'); | ||
|
||
base.runTest({ | ||
pattern: /^{/, | ||
code: `function f() { | ||
require('vm').runInDebugContext('Debug'); | ||
setImmediate(function() { f(); }); | ||
}; | ||
f();`, | ||
profProcessFlags: ['--preprocess'] | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c948ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasnell: This commit message does not conform to our standards (no subsystem). Probably not worth force-pushing over at this point, but uh, in case it is, I'm mentioning it...
(Use
core-validate-commit
from @evanlucas to catch these things before pushing!)7c948ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh crap... that's what i get for landing PRs while I'm on the phone. Completely overlooked that! My apologies!
7c948ce
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(and for what it's worth, I have a script that checks these already, it just requires that I actually look at the warnings it prints... unlike core-validate-commit it doesn't block. It's likely a good idea to change to evan's tool :-)