Skip to content

Commit

Permalink
test: do not modify fixtures in test-fs-chmod
Browse files Browse the repository at this point in the history
`test-fs-chmod` modifies the permissions on files in `test/fixtures`.
This change has the test use the temp directory instead. One of the
fixture files is not used by any other test, so it has been deleted.

I took this opportunity to remove `console.log()` statements from the
test.

PR-URL: #14926
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
Trott authored and MylesBorins committed Sep 20, 2017
1 parent 168f73c commit 644d990
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 34 deletions.
25 changes: 0 additions & 25 deletions test/fixtures/a1.js

This file was deleted.

17 changes: 8 additions & 9 deletions test/parallel/test-fs-chmod.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,17 @@ if (common.isWindows) {
mode_sync = 0o644;
}

const file1 = path.join(common.fixturesDir, 'a.js');
const file2 = path.join(common.fixturesDir, 'a1.js');
common.refreshTmpDir();

const file1 = path.join(common.tmpDir, 'a.js');
const file2 = path.join(common.tmpDir, 'a1.js');

// Create file1.
fs.closeSync(fs.openSync(file1, 'w'));

fs.chmod(file1, mode_async.toString(8), common.mustCall((err) => {
assert.ifError(err);

console.log(fs.statSync(file1).mode);

if (common.isWindows) {
assert.ok((fs.statSync(file1).mode & 0o777) & mode_async);
} else {
Expand All @@ -72,14 +75,12 @@ fs.chmod(file1, mode_async.toString(8), common.mustCall((err) => {
}
}));

fs.open(file2, 'a', common.mustCall((err, fd) => {
fs.open(file2, 'w', common.mustCall((err, fd) => {
assert.ifError(err);

fs.fchmod(fd, mode_async.toString(8), common.mustCall((err) => {
assert.ifError(err);

console.log(fs.fstatSync(fd).mode);

if (common.isWindows) {
assert.ok((fs.fstatSync(fd).mode & 0o777) & mode_async);
} else {
Expand All @@ -101,13 +102,11 @@ fs.open(file2, 'a', common.mustCall((err, fd) => {
if (fs.lchmod) {
const link = path.join(common.tmpDir, 'symbolic-link');

common.refreshTmpDir();
fs.symlinkSync(file2, link);

fs.lchmod(link, mode_async, common.mustCall((err) => {
assert.ifError(err);

console.log(fs.lstatSync(link).mode);
assert.strictEqual(mode_async, fs.lstatSync(link).mode & 0o777);

fs.lchmodSync(link, mode_sync);
Expand Down

0 comments on commit 644d990

Please sign in to comment.