Skip to content

Commit

Permalink
test: remove eslint-disable comments from fixtures
Browse files Browse the repository at this point in the history
We do not lint the fixtures code so eslint-disable comments are
superfluous.

PR-URL: #41859
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott authored and ruyadorno committed Feb 8, 2022
1 parent f8acca8 commit 573cafe
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 8 deletions.
1 change: 0 additions & 1 deletion test/fixtures/es-module-loaders/loader-invalid-url.mjs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable node-core/required-modules */
export async function resolve(specifier, { parentURL, importAssertions }, defaultResolve) {
if (parentURL && specifier === '../fixtures/es-modules/test-esm-ok.mjs') {
return {
Expand Down
1 change: 0 additions & 1 deletion test/fixtures/es-module-loaders/throw-undefined.mjs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
'use strict';
/* eslint-disable node-core/required-modules */

throw undefined;
1 change: 0 additions & 1 deletion test/fixtures/es-modules/import-json-named-export.mjs
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
/* eslint-disable no-unused-vars */
import { ofLife } from '../experimental.json' assert { type: 'json' };
1 change: 0 additions & 1 deletion test/fixtures/wpt/streams/readable-streams/general.any.js
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,6 @@ promise_test(() => {
let pullCalled = 0;
let cancelCalled = 0;

/* eslint-disable no-use-before-define */
class Source {
start(c) {
startCalled++;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ test(t => {

const trappedProperties = ['highWaterMark', 'size', 'start', 'type', 'mode'];
for (const property of trappedProperties) {
// eslint-disable-next-line no-extend-native, accessor-pairs
Object.defineProperty(Object.prototype, property, {
get() { throw new Error(`${property} getter called`); },
configurable: true
Expand Down
1 change: 0 additions & 1 deletion test/fixtures/wpt/streams/resources/test-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ self.garbageCollect = () => {
// Present in some WebKit development environments
GCController.collect();
} else {
/* eslint-disable no-console */
console.warn('Tests are running without the ability to do manual garbage collection. They will still work, but ' +
'coverage will be suboptimal.');
/* eslint-enable no-console */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,11 @@
// interfering with other tests.

test(t => {
// eslint-disable-next-line no-extend-native, accessor-pairs
Object.defineProperty(Object.prototype, 'highWaterMark', {
set() { throw new Error('highWaterMark setter called'); },
configurable: true
});

// eslint-disable-next-line no-extend-native, accessor-pairs
Object.defineProperty(Object.prototype, 'size', {
set() { throw new Error('size setter called'); },
configurable: true
Expand Down

0 comments on commit 573cafe

Please sign in to comment.