http2: compat req.complete

PR-URL: #28627 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
nodejs · Jul 22, 2019 · 49e4d72 · 49e4d72
1 parent 74243da
commit 49e4d72
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lib/internal/http2/compat.js b/lib/internal/http2/compat.js
@@ -302,7 +302,8 @@ class Http2ServerRequest extends Readable {
   }
 
   get complete() {
-    return this._readableState.ended ||
+    return this[kAborted] ||
+           this._readableState.ended ||
            this[kState].closed ||
            this[kStream].destroyed;
   }

diff --git a/test/parallel/test-http2-compat-aborted.js b/test/parallel/test-http2-compat-aborted.js
@@ -10,8 +10,10 @@ const assert = require('assert');
 const server = h2.createServer(common.mustCall(function(req, res) {
   req.on('aborted', common.mustCall(function() {
     assert.strictEqual(this.aborted, true);
+    assert.strictEqual(this.complete, true);
   }));
   assert.strictEqual(req.aborted, false);
+  assert.strictEqual(req.complete, false);
   res.write('hello');
   server.close();
 }));