url: check forEach callback is a function

Per spec.
nodejs · Jan 20, 2017 · 44acced · 44acced
1 parent f0f65de
commit 44acced
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -817,6 +817,9 @@ class URLSearchParams {
     if (arguments.length < 1) {
       throw new TypeError('The `callback` argument needs to be specified');
     }
+    if (typeof callback !== 'function') {
+      throw new TypeError('The `callback` argument must be a function');
+    }
 
     let list = this[searchParams];
 

diff --git a/test/parallel/test-whatwg-url-searchparams.js b/test/parallel/test-whatwg-url-searchparams.js
@@ -54,6 +54,8 @@ sp.forEach(function(val, key, obj) {
 sp.forEach(function() {
   assert.strictEqual(this, m);
 }, m);
+assert.throws(() => sp.forEach(), TypeError);
+assert.throws(() => sp.forEach(1), TypeError);
 
 m.search = '?a=a&b=b';
 assert.strictEqual(sp.toString(), 'a=a&b=b');