Skip to content

Commit

Permalink
test: add comments and rename test for timer robustness
Browse files Browse the repository at this point in the history
The name of the test did not make it clear what it was about. (It also
used "timer" in the name instead of "timers" like all the other tests.)
I also added a comment to be extra clear about the test purpose and a
link to the issue that was originally filed about it.

PR-URL: #54008
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
  • Loading branch information
Trott authored and targos committed Jul 28, 2024
1 parent 13c2aa5 commit 321e9f2
Showing 1 changed file with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Check that setImmediate works even if process is tampered with.
// This is a regression test for https://github.com/nodejs/node/issues/17681.

'use strict';
const common = require('../common');
global.process = {}; // Boom!
Expand Down

0 comments on commit 321e9f2

Please sign in to comment.