Skip to content

Commit

Permalink
src: fix method name, output format
Browse files Browse the repository at this point in the history
* add additional newline to HTTP GET JSON responses
* SendTargentsListResponse -> SendListResponse

PR-URL: #9627
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
joshgav authored and addaleax committed Nov 20, 2016
1 parent 3295a7f commit 31dac41
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/inspector_agent.cc
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ std::string MapToString(const std::map<std::string, std::string> object) {
json << name_value.second << "\"";
first = false;
}
json << "\n} ]";
json << "\n} ]\n\n";
return json.str();
}

Expand Down Expand Up @@ -250,7 +250,7 @@ class AgentImpl {
void WaitForFrontendMessage();
void NotifyMessageReceived();
State ToState(State state);
void SendTargentsListResponse(InspectorSocket* socket);
void SendListResponse(InspectorSocket* socket);
bool RespondToGet(InspectorSocket* socket, const std::string& path);

uv_sem_t start_sem_;
Expand Down Expand Up @@ -677,7 +677,7 @@ void AgentImpl::OnRemoteDataIO(InspectorSocket* socket,
}
}

void AgentImpl::SendTargentsListResponse(InspectorSocket* socket) {
void AgentImpl::SendListResponse(InspectorSocket* socket) {
std::map<std::string, std::string> response;
response["description"] = "node.js instance";
response["faviconUrl"] = "https://nodejs.org/static/favicon.ico";
Expand Down Expand Up @@ -710,7 +710,7 @@ bool AgentImpl::RespondToGet(InspectorSocket* socket, const std::string& path) {
return false;

if (match_path_segment(command, "list") || command[0] == '\0') {
SendTargentsListResponse(socket);
SendListResponse(socket);
return true;
} else if (match_path_segment(command, "protocol")) {
SendProtocolJson(socket);
Expand Down

0 comments on commit 31dac41

Please sign in to comment.