Skip to content

Commit

Permalink
test: refactor test-domain-exit-dispose-again
Browse files Browse the repository at this point in the history
setTimeout at 49:5 requires two arguments.

On lines 72 and 73 changed assert.equal() to assert.strictEqual().

PR-URL: #10003
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
Ethan-Arrowood authored and MylesBorins committed Dec 20, 2016
1 parent 8a9af68 commit 1377ea8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions test/parallel/test-domain-exit-dispose-again.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ setTimeout(function firstTimer() {
'a domain that should be disposed.');
disposalFailed = true;
process.exit(1);
});
}, 1);

// Make V8 throw an unreferenced error. As a result, the domain's error
// handler is called, which disposes the domain "d" and should prevent the
Expand All @@ -69,8 +69,8 @@ setTimeout(function secondTimer() {
}, TIMEOUT_DURATION);

process.on('exit', function() {
assert.equal(a, 10);
assert.equal(disposalFailed, false);
assert.strictEqual(a, 10);
assert.strictEqual(disposalFailed, false);
assert(secondTimerRan);
console.log('ok');
});

0 comments on commit 1377ea8

Please sign in to comment.