Skip to content

Commit

Permalink
doc: update onboarding task
Browse files Browse the repository at this point in the history
Make starting Jenkins CI optional.

PR-URL: #40570
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
Trott authored and targos committed Nov 6, 2021
1 parent 08e7a2f commit 132f6cb
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion onboarding.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,9 @@ needs to be pointed out separately during the onboarding.
labels. The `fast-track` label should cause the Node.js GitHub bot to post a
comment in the pull request asking collaborators to approve the pull request
by leaving a 👍 reaction on the comment.
* Run CI on the pull request. Use the `node-test-pull-request` CI task.
* Optional: Run CI on the pull request. Use the `node-test-pull-request` CI
task. As a convenience, you may apply the `request-ci` label to the pull
request to have a GitHub Actions workflow start the Jenkins CI task for you.
* After two Collaborator approvals for the change and two Collaborator approvals
for fast-tracking, land the PR.
* If there are not enough approvals within a reasonable time, consider the
Expand Down

0 comments on commit 132f6cb

Please sign in to comment.