Skip to content

Commit

Permalink
build: fixed clang's warning when building openssl
Browse files Browse the repository at this point in the history
clang doesn't seem to support 'Wno-old-style-declaration', this
is a work-around.

Fixes: #25550
Refs: nodejs/node-v0.x-archive#4186

PR-URL: #25954
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
thangktran authored and richardlau committed Feb 15, 2019
1 parent 51d20b6 commit 128170f
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions deps/openssl/openssl_common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,17 @@
],
}, {
# linux and others
'cflags': ['-Wno-missing-field-initializers',
## TODO: check gcc_version>=4.3
'-Wno-old-style-declaration'],
'cflags': ['-Wno-missing-field-initializers',],
'defines': [
'OPENSSLDIR="/etc/ssl"',
'ENGINESDIR="/dev/null"',
'TERMIOS',
],
'conditions': [
[ 'llvm_version==0', {
'cflags': ['-Wno-old-style-declaration',],
}],
],
}],
]
}

0 comments on commit 128170f

Please sign in to comment.