Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

src: fix builtin modules failing with --use-strict #9237

Closed
wants to merge 1 commit into from
Closed

src: fix builtin modules failing with --use-strict #9237

wants to merge 1 commit into from

Commits on Feb 27, 2015

  1. src: fix builtin modules failing with --use-strict 

    Currently, lib/_tls_legacy.js and lib/crypto.js cannot be loaded when
--use-strict is passed to node. In addition to that, console.trace
throws because it uses arguments.callee.

This change fixes these issues and adds a test that makes sure
every external built-in module can be loaded with require when
--use-strict is enabled.

Please note that this change does not fix all issues with built-in
modules' code running with --use-strict. It is very likely that some
code in the built-in modules still fails when passing this flag.

However, fixing all code would require us to enable strict mode by
default in all builtins modules, which would certainly break existing
applications.

Fixes nodejs#9187.
    Julien Gilli committed Feb 27, 2015
    Configuration menu
    Copy the full SHA
    d51f79e View commit details
    Browse the repository at this point in the history