This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Update root certificates #25829
Closed
Update root certificates #25829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no code to download it automatically but the mk-ca-bundle.pl file document the url at the top. The url documented is the one before mozilla moved to mercurial as VCS and wasn't updated for 3 years. The new one is the certificate bundle for the current stable release of Firefox.
Update the certificate data in certdata.txt and node_root_certs.h with the current Mozilla version. Version is aa275ad846f1 with latest update on 2015-04-20 as distributed in Firefox 39.
|
Seem like the corresponding update was already in io.js : nodejs/node#1833 Depending on the timeline for the unified version it would be interesting to update the certificate in nodej before the merge to avoid giving errors on valid https websites. |
|
@vbfox this would need to be opened as a PR against the v0.12 branch. Otherwise, we'll pick up the changes from nodejs/node in the converged repo. I recommend closing this particular PR and if you'd like to pursue a change to v0.12, open a new one targeted there please :-) Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current root certificate bundle is out-of-date. I noticed it while I wanted to use https://keybase.io tools to certifiy my domain name.
This pull request update the
$urlthat is used only as documentation inmk-ca-bundle.plwith the correct one (The URL changed when mozilla moved to Mercurial)And I also updated the certificate bundle itself with the version aa275ad846f1 (Same as Firefox 39, latest change on 2015-04-20)