This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
build: work around VS2015 issue in ICU <56 (master) #25793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probably fixes nodejs#25792 Also, adds general mechanism for floating patches on top of ICU. The particular ufile.c is from http://bugs.icu-project.org/trac/changeset/37704 and should be OK for ICU 54 and 55. backport from: nodejs/node#2283
|
@orangemocha I couldn't get this to build against VS2015 , it said "setting up environment for VS2010…". So, this is not tested sorry. But the mechanism works as merged, I just can't cleanly test it yet. |
|
Pending review at nodejs/node#2283 and testing. This should go into v0.12 though, not master, right? |
|
@orangemocha good question. It needs to go anywhere that wants to build against vs2015 - what do you advise? |
|
@srl295 then it should go first in the oldest LTS version that has ICU support. Assuming icu is not supported in v0.10, this change should go into v0.12. Thanks! |
|
@orangemocha Sounds good. OK, I will close this PR and reopen against v0.12 |
srl295
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probably fixes #25792
Also, adds general mechanism for floating patches on top of ICU.
The particular ufile.c is from
http://bugs.icu-project.org/trac/changeset/37704
and should be OK for ICU 54 and 55.
backport from: nodejs/node#2283