Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to glob@7.0.3. #943

Merged
merged 1 commit into from
May 31, 2016
Merged

Upgrade to glob@7.0.3. #943

merged 1 commit into from
May 31, 2016

Conversation

bnoordhuis
Copy link
Member

Matches what npm v2.15.5 and npm v3.8.6 use.

Fixes: #941

R=@rvagg?

@Fishrock123
Copy link
Contributor

lgtm if it works I suppose.

Tests pass here.

@rvagg
Copy link
Member

rvagg commented May 31, 2016

Yeah, LGTM.

I can't find info on what broken between 3||4 and 7 but given that our only single usage is to look up 'build/*.sln' I can't imagine we could go wrong anywhere.

While you're in there, you could remove the glob require in lib/configure.js, it's not used.

@bnoordhuis
Upgrade to glob@7.0.3.
ac29d23 
Matches what npm v2.15.5 and npm v3.8.6 use.

Fixes: #941
PR-URL: #943
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@bnoordhuis bnoordhuis merged commit ac29d23 into nodejs:master May 31, 2016
@bnoordhuis bnoordhuis deleted the glob branch May 31, 2016 07:43
@bnoordhuis
Copy link
Member Author

Landed in ac29d23 with the usage in lib/configure.js removed. Thanks for the reviews.

@rvagg rvagg mentioned this pull request Jun 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnoordhuis @Fishrock123 @rvagg