Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: GitHub Actions enable python-version: 3.5 #1995

Closed
wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 16, 2019

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

And upgrade actions/checkout@v1 to v2
@rvagg rvagg force-pushed the GitHub-Actions-enable-Python-3.5 branch from 8888281 to c4e5abe Compare December 30, 2019 02:53
@rvagg
Copy link
Member

rvagg commented Dec 30, 2019

rebased and squashed properly and force pushed back to your branch @cclauss, rebase against your remote for this branch or check it out fresh if you want to edit it.
3.5 still failing across the board

@rvagg
Copy link
Member

rvagg commented Jan 6, 2020

reran, not failing on macos but 3.5 failing on windows & ubuntu, looks flaky though because for ubuntu it passed on pull_request but not push, weird

@cclauss
Copy link
Contributor Author

cclauss commented Oct 7, 2020

Python 3.5 is end of life.

@cclauss cclauss closed this Oct 7, 2020
@cclauss cclauss deleted the GitHub-Actions-enable-Python-3.5 branch October 7, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants