Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.x Python compat fixes for README #1911

Closed
wants to merge 7 commits into from
Closed

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Oct 4, 2019

When backporting #1908 I noticed that it leaves README in a weird 1/2 way state, still stating that it needs Python 2.7.

This PR adds #1908 plus additional changes required to make README match master. I don't believe there's anything different that needs to be said between the two at this stage.

The only minor difference is in the initial list of requirements, master has "Python v2.7, v3.5, v3.6, or v3.7", this one just has "Python v2.7, v3.5, v3.6, or v3.7" (no backticks). I'll PR that to master.

@cclauss @joaocgreis @sam-github any of you around to +1 this so I can get a 5.0.5 out with it?

sam-github and others added 5 commits October 4, 2019 13:37
Python 3 is allowed as a compatible Python, but its looked for after
Python 2.

rvagg: removed additional EXPERIMENTAL_NODE_GYP_PYTHON3 in
.travis.yml from a previous commit while landing.

Backport-of: #1844
PR-URL: #1910
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: João Reis <reis@janeasystems.com>
Fixes: #1881
PR-URL: #1902
Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: #1904
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Clarify that:
- node-gyp is not used to build Node.js
- PYTHON can be used to add a Python search path
- NODE_GYP_FORCE_PYTHON can be used to override all Python search paths
- That a compatible Python is searched for

PR-URL: #1908
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@rvagg rvagg mentioned this pull request Oct 4, 2019
@rvagg
Copy link
Member Author

rvagg commented Oct 4, 2019

added fixup commit to bring back 2.6 support in docs ... will need to do another PR to bring it back in find-python.js

@rvagg
Copy link
Member Author

rvagg commented Oct 4, 2019

removed mention of 2.6 in here, it's only "supported" in the sense the our semverRange has it included for 5.x

rvagg added a commit that referenced this pull request Oct 4, 2019
PR-URL: #1911
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@rvagg
Copy link
Member Author

rvagg commented Oct 4, 2019

landed in v5.x as 3891391

@rvagg rvagg closed this Oct 4, 2019
@rvagg rvagg deleted the rvagg/python3-doc-fixes branch October 4, 2019 12:39
@cclauss cclauss added the Python label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants