Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text in readme in wrong place #1295

Closed
mscdex opened this issue Sep 19, 2017 · 2 comments · Fixed by #1323
Closed

text in readme in wrong place #1295

mscdex opened this issue Sep 19, 2017 · 2 comments · Fixed by #1323
Labels
Documentation

Comments

@mscdex
Copy link
Contributor

mscdex commented Sep 19, 2017

  • Node Version: n/a
  • Platform: Windows
  • Compiler: n/a
  • Module: n/a

Under the "On Windows" installation section there is a blurb about macOS that should be moved back into the "On Mac OS X" installation section:

Note that OS X is just a flavour of Unix and so needs python, make, and C/C++. An easy way to obtain these is to install XCode from Apple, and then use it to install the command line tools (under Preferences -> Downloads).
@andrwsalcdo
Copy link

Can I take this one? new contributor.

@mscdex
Copy link
Contributor Author

mscdex commented Sep 26, 2017

@andrwsalcdo Sure, go for it.

@josh- josh- mentioned this issue Jan 16, 2018
Merged
4 tasks
maclover7 pushed a commit that referenced this issue Jun 8, 2018
@josh- @maclover7
doc: update macOS information in README
91789c2 
PR-URL: #1323
Fixes: #1295
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: update macOS information in README josh-/node-gyp
2 participants
@mscdex @andrwsalcdo