Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing await #655

Merged
merged 1 commit into from
Oct 27, 2022
Merged

fix: add missing await #655

merged 1 commit into from
Oct 27, 2022

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Oct 27, 2022

This should fix the (additional) issue mentioned in #653 (comment)

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 83.60% // Head: 83.60% // No change to project coverage 👍

Coverage data is based on head (31f2005) compared to base (04d513d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #655   +/-   ##
=======================================
  Coverage   83.60%   83.60%           
=======================================
  Files          37       37           
  Lines        4117     4117           
=======================================
  Hits         3442     3442           
  Misses        675      675           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MoLow
Copy link
Member Author

MoLow commented Oct 27, 2022

CC @richardlau @aduh95

@aduh95 aduh95 merged commit 7e4dc88 into nodejs:main Oct 27, 2022
@aduh95
Copy link
Contributor

aduh95 commented Oct 27, 2022

It definitely improved things, now the request-ci-failed label is added – the comment from the bot could be more helpful though nodejs/node#45209 (comment) 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants