Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wpt): download files as buffer instead of text #535

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

targos
Copy link
Member

@targos targos commented Feb 21, 2021

There are binary files in the WPT repository and downloading them as
text corrupts them.

Refs: nodejs/node#37294

@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #535 (d97f83c) into master (059c138) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #535   +/-   ##
=======================================
  Coverage   82.51%   82.51%           
=======================================
  Files          35       35           
  Lines        1744     1744           
=======================================
  Hits         1439     1439           
  Misses        305      305           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 059c138...d97f83c. Read the comment docs.

There are binary files in the WPT repository and downloading them as
text corrupts them.

Refs: nodejs/node#37294
@joyeecheung joyeecheung merged commit d6fad2a into nodejs:master Feb 22, 2021
@targos targos deleted the fix-wpt branch February 22, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants