Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pr_checker.js #287

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Update pr_checker.js #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/pr_checker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ class PRChecker {
const dateStr = new Date(pr.createdAt).toDateString();
const type = wait.isWeekend ? 'weekend' : 'weekday';
cli.info(`This PR was created on ${dateStr} (${type} in UTC)`);
cli.warn(`${wait.timeLeft} hours left to land`);
cli.warn(`Wait at least ${wait.timeLeft} more hours before landing`);
return false;
}

Expand Down
4 changes: 2 additions & 2 deletions test/unit/pr_checker.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ describe('PRChecker', () => {
const cli = new TestCLI();

const expectedLogs = {
warn: [['49 hours left to land']],
warn: [['Wait at least 49 more hours before landing']],
info: [['This PR was created on Sat Oct 28 2017 (weekend in UTC)']]
};

Expand Down Expand Up @@ -201,7 +201,7 @@ describe('PRChecker', () => {
const cli = new TestCLI();

const expectedLogs = {
warn: [['22 hours left to land']],
warn: [['Wait at least 22 more hours before landing']],
info: [['This PR was created on Tue Oct 31 2017 (weekday in UTC)']]
};

Expand Down