Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken git-node v8 backport #603

Closed
targos opened this issue Jan 18, 2022 · 1 comment · Fixed by #636
Closed

Broken git-node v8 backport #603

targos opened this issue Jan 18, 2022 · 1 comment · Fixed by #636
Labels
bug

Comments

@targos
Copy link
Member

targos commented Jan 18, 2022 

$ git node v8 --v8-dir ~/git/chromium/v8/v8 backport 80bbbb143c2449f7a2109424a937d1887043c9ee
✔ Update local V8 clone
❯ V8 commit backport
  ✔ Get current V8 version
  ✔ Generate patches
  ❯ Apply and commit patches to deps/v8
    ❯ Commit 80bbbb143c24
      ✖ Enquirer is a peer dependency that must be installed separately.
      ◼ Increment embedder version number
      ◼ Commit patch
✖ Enquirer is a peer dependency that must be installed separately.
@targos targos added the bug label Jan 18, 2022
@XadillaX
Copy link
Contributor

XadillaX commented Jun 6, 2022

I have this problem too.

XadillaX added a commit to XadillaX/node-core-utils that referenced this issue Jun 6, 2022
@XadillaX
fix: broken enquirer in listr2
6383d9f 
Refs: listr2/listr2#631
Fixes: nodejs#603
@XadillaX XadillaX mentioned this issue Jun 6, 2022
Merged
targos pushed a commit that referenced this issue Jun 22, 2022
@XadillaX
fix: broken enquirer in listr2 (#636)
460b50d 
Refs: listr2/listr2#631
Fixes: #603
johnfrench3 pushed a commit to johnfrench3/core-utils-node that referenced this issue Nov 2, 2022
fix: broken enquirer in listr2 (#636)
50533b9 
Refs: listr2/listr2#631
Fixes: nodejs/node-core-utils#603
renawolford6 added a commit to renawolford6/node-dev-build-core-utils that referenced this issue Nov 10, 2022
@renawolford6
fix: broken enquirer in listr2 (#636)
205c217 
Refs: listr2/listr2#631
Fixes: nodejs/node-core-utils#603
Developerarif2 pushed a commit to Developerarif2/node-core-utils that referenced this issue Jan 27, 2023
@logictitans
fix: broken enquirer in listr2 (#636)
41e9110 
Refs: listr2/listr2#631
Fixes: nodejs/node-core-utils#603
gerkai added a commit to gerkai/node-core-utils-project-build that referenced this issue Jan 27, 2023
@gerkai
fix: broken enquirer in listr2 (#636)
45d614e 
Refs: listr2/listr2#631
Fixes: nodejs/node-core-utils#603
shovon58 pushed a commit to shovon58/node-core-utils that referenced this issue Jun 9, 2023
@paxaxel223
fix: broken enquirer in listr2 (#636)
dc4b379 
Refs: listr2/listr2#631
Fixes: nodejs/node-core-utils#603
patrickm68 added a commit to patrickm68/NodeJS-core-utils that referenced this issue Sep 14, 2023
@patrickm68
fix: broken enquirer in listr2 (#636)
6b8d56d 
Refs: listr2/listr2#631
Fixes: nodejs/node-core-utils#603
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: broken enquirer in listr2 XadillaX/node-core-utils
2 participants
@targos @XadillaX