Add support for <= v0.12 releases #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if [ "X$2" == "X" ]; then | ||
| echo "Usage: promote_nightly.sh < iojs | nodejs > <version>" | ||
| echo "Usage: promote_nightly.sh < iojs | nodejs >" |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
9 tasks
rvagg
force-pushed
the
pre-1-releases
branch
from
472be59
to
d175858
Compare
|
added |
| @@ -3,5 +3,5 @@ JENKINS_SLAVE_JAR="/home/iojs/slave.jar" | |||
| JENKINS_SLAVE_LOG="/home/iojs/$NAME.log" | |||
| JENKINS_SECRET="{{secret}}" | |||
| JENKINS_SLAVE_ARGS="-jnlpUrl https://ci.nodejs.org/computer/iojs-digitalocean-centos6-64-{{id}}/slave-agent.jnlp -secret $JENKINS_SECRET" | |||
| JENKINS_ENV="DESTCPU={{arch}} ARCH={{arch}} OSTYPE=linux-gnu NODE_COMMON_PIPE=/home/iojs/test.pipe" | |||
| JENKINS_ENV="PRE_1_PATH=/home/iojs/bin:$PATH JOBS=$(getconf _NPROCESSORS_ONLN) DESTCPU={{arch}} ARCH={{arch}} OSTYPE=linux-gnu NODE_COMMON_PIPE=/home/iojs/test.pipe" | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM with optional readability nit. |
rvagg
force-pushed
the
pre-1-releases
branch
from
d175858
to
6fbc50a
Compare
|
@jbergstroem is this OK? |
|
@rvagg sorry - should have elaborated. JENKINS_PATH gets passed to the binary through the init script. My suggestion was to move your path juggling to the JENKINS_PATH env since thats already used for the same purpose. I guess we're down to semantics so feel free to commit whatever's working for you. |
|
LGTM |
rvagg
force-pushed
the
pre-1-releases
branch
2 times, most recently
from
9e8a888
to
976d8a8
Compare
rvagg
force-pushed
the
pre-1-releases
branch
from
976d8a8
to
bca1eb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For both centos5 release slaves and the web server for the promotion scripts.