Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: remove smartos test machines #2030

Merged
merged 1 commit into from
Nov 6, 2019
Merged

ansible: remove smartos test machines #2030

merged 1 commit into from
Nov 6, 2019

Conversation

sam-github
Copy link
Contributor

See: #2014

@sam-github
Copy link
Contributor Author

After this merges I'll remove the machines from https://ci.nodejs.org/computer/

@sam-github
Copy link
Contributor Author

@cclauss :headscratching: I didn't touch any python, is the flake8 test invalid?

@richardlau
Copy link
Member

@cclauss :headscratching: I didn't touch any python, is the flake8 test invalid?

Looks like it was broken by #2024.

@cclauss
Copy link
Contributor

cclauss commented Nov 5, 2019

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sam-github
Copy link
Contributor Author

I removed the machines from jenkins.

@sam-github sam-github merged commit 14ae6f0 into nodejs:master Nov 6, 2019
@sam-github sam-github deleted the remove-smartos-test branch November 6, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants