Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: only test FreeBSD 11 on <= Node.js 12 thanks to clang 6 #1973

Closed
wants to merge 1 commit into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Oct 21, 2019

Ref: #1970
Ref: nodejs/node#30020

FreeBSD 11 comes with clang 6.0.0. configure.py states we have a minimum of 8.0.0 (though not BUILDING.md). V8 7.9 @ nodejs/node#30020 is having problems with older gcc but it compiles OK on FreeBSD 11, with just one test failing.

Two questions for this PR:

  1. Is clang 8.0.0 a real minimum requirement or just a guess? Should it disqualify FreeBSD 11?
  2. What is the likelihood of V8 7.9 going into Node 13.x? I've crafted this PR to exclude it from >=13 because of this assumption, but maybe that's not a safe assumption if 7.9 is going to break real compiler minimums, not just what we state in BUILDING.md (i.e. someone can compile 13.x today with their gcc 5, but in a month they won't be able to because 7.9 is there and having problems).

Also we don't have anything newer than FreeBSD 11 so maybe we should ditch all our FreeBSD machines and put in some fresh new 12 ones and start from scratch?

@targos @richardlau @nodejs/build @nodejs/platform-freebsd

@richardlau
Copy link
Member

1. Is clang 8.0.0 a _real_ minimum requirement or just a guess? Should it disqualify FreeBSD 11?

It was bumped up to 8.0.0 (previously 3.4.2) for Node.js 12 to match the LLVM version in XCode 8 for macOS: nodejs/node#26719 (comment)

I don't know if it's a real minimum in general. Do V8 document their minimum compiler requirements anywhere?

@rvagg
Copy link
Member Author

rvagg commented Oct 21, 2019

I don't think they do, historically it's been up to us to bump into the edgecases and bump it on our end. @targos?

@targos
Copy link
Member

targos commented Oct 21, 2019

I'm not aware of documented compiler requirements.
This page says that Chromium (and I assume V8) supports C++14 but not C++17 yet: https://chromium-cpp.appspot.com

C++14 is supported in Clang 3.4 and later.

I'm not too concerned about using Clang 6 for now. We'll see when we have issues with it.

@rvagg rvagg closed this Oct 27, 2019
@rvagg rvagg deleted the rvagg/freebsd-11-pre13 branch October 27, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants