Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move inactive releasers to emeritus #784

Merged
merged 2 commits into from
Oct 6, 2022
Merged

chore: move inactive releasers to emeritus #784

merged 2 commits into from
Oct 6, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 27, 2022

"Releasers have access to critical infrastructure in the project - this elevated access must be restricted to active releasers. Members of the releasers team should be offboarded when they no longer intend to prepare releases. As a guideline, offboarding should be considered if a releaser has not prepared a release in the past 12 months."

Refs: https://github.com/nodejs/Release/blob/main/GOVERNANCE.md#offboarding-releasers

@Trott
Copy link
Member Author

Trott commented Sep 27, 2022

@nodejs/releasers

README.md Outdated Show resolved Hide resolved
@BethGriggs
Copy link
Member

BethGriggs commented Sep 27, 2022

After this lands, it might be a good time to try and tackle #499 (which includes cleaning up lingering SSH keys from the dist server). We're probably well overdue some housekeeping on there.

"Releasers have access to critical infrastructure in the project - this
elevated access must be restricted to active releasers. Members of the
releasers team should be offboarded when they no longer intend to prepare
releases. As a guideline, offboarding should be considered if a releaser has
not prepared a release in the past 12 months."

Refs: https://github.com/nodejs/Release/blob/main/GOVERNANCE.md#offboarding-releasers
@MylesBorins
Copy link
Contributor

I'd like to remain on the release team if possible. I am heading on paternity leave and will be out until January, so this can wait until I return. While I don't actively prepare releases I think it is prudent to keep an npm adjacent team member on the team in case of npm related releases being created. So alternatively someone else from the team could step up and get involved in my absence.

How do folks feel about that?

@Trott
Copy link
Member Author

Trott commented Sep 28, 2022

I'd like to remain on the release team if possible. I am heading on paternity leave and will be out until January, so this can wait until I return. While I don't actively prepare releases I think it is prudent to keep an npm adjacent team member on the team in case of npm related releases being created. So alternatively someone else from the team could step up and get involved in my absence.

How do folks feel about that?

The 12-months thing is presented as a "guideline" and not a hard-and-fast rule, so the Release team can certainly choose to make an exception like that.

@Trott
Copy link
Member Author

Trott commented Oct 6, 2022

I've removed @cjihrig @jasnell @BridgeAR and @codebytere from the GitHub team and will land this now. Thanks, everyone.

I'll see if I can find a releaser offboarding doc to see if there are other steps (or an onboarding doc that can be reversed as an offboarding doc).

@Trott Trott merged commit 3cd3c6a into main Oct 6, 2022
@Trott Trott deleted the emeritus branch October 6, 2022 00:16
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Oct 7, 2022
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: nodejs/Release#784
PR-URL: #44899
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
danielleadams pushed a commit to nodejs/node that referenced this pull request Oct 11, 2022
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: nodejs/Release#784
PR-URL: #44899
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants